Log TaskStarted line and column #6399
Conversation
We currently log the file in which a task is invoked, but we don't log the line and column, so if there are multiple tasks of the same name in a target, there's an ambiguity as to which task it is. Pass the line and column information to TaskStartedEventArgs. Fortunately we don't need to increment the binlog file format as we can piggy-back on the existing infrastructure for messages which can already log line and column if present. Reading older binlogs with the new MSBuild will work as the line and column flags won't be set, so no attempt to read anything extra. Reader newer binlogs with old MSBuild (same version but pre-this change) will also work as the line and column fields will be set and the existing infrastructure will read them, but nothing will consume that data.
KirillOsenkov
added
Area: Debuggability
| LineNumber = reader.Read7BitEncodedInt(); | ||
| ColumnNumber = reader.Read7BitEncodedInt(); |
There was a problem hiding this comment.
Like @Forgind I also wonder if the change is backward compatible. Shouldn't you be testing for BuildEventArgsFieldFlags.LineNumber and BuildEventArgsFieldFlags.ColumnNumber here before reading the integers?
There was a problem hiding this comment.
Ah, I think I understand. This code is separate from the binlog logic and has no versioning concerns, is that correct?
There was a problem hiding this comment.
Yes, this is unrelated to binlog and used by the node packet translator to send events from worker nodes to central node. Nodes will only talk to each other if they’re the same MSBuild version.
| LineNumber = reader.Read7BitEncodedInt(); | ||
| ColumnNumber = reader.Read7BitEncodedInt(); |
There was a problem hiding this comment.
Ah, I think I understand. This code is separate from the binlog logic and has no versioning concerns, is that correct?
Forgind
added
the
merge-when-branch-open
We currently log the file in which a task is invoked, but we don't log the line and column, so if there are multiple tasks of the same name in a target, there's an ambiguity as to which task it is.
Pass the line and column information to TaskStartedEventArgs.
Fortunately we don't need to increment the binlog file format as we can piggy-back on the existing infrastructure for messages which can already log line and column if present. Reading older binlogs with the new MSBuild will work as the line and column flags won't be set, so no attempt to read anything extra. Reader newer binlogs with old MSBuild (same version but pre-this change) will also work as the line and column fields will be set and the existing infrastructure will read them, but nothing will consume that data.