Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProjectStarted.GlobalProperties is expected to be not-null #6341

Closed
KirillOsenkov opened this issue Apr 13, 2021 · 1 comment · Fixed by #6342
Closed

ProjectStarted.GlobalProperties is expected to be not-null #6341

KirillOsenkov opened this issue Apr 13, 2021 · 1 comment · Fixed by #6342
Assignees
@KirillOsenkov
Labels
Area: Logging triaged

Comments

@KirillOsenkov
Copy link
Member

There are loggers (reported by @AndyGerlicher) that expect ProjectStartedEventArgs.GlobalProperties to be not null and set. It would take a long time to transition those loggers to the new way where these are logged on ProjectEvaluationFinishedEventArgs.

Bring back GlobalProperties for backwards compat.
@KirillOsenkov KirillOsenkov self-assigned this Apr 13, 2021
@KirillOsenkov
Copy link
Member Author

See #6287 where this regressed.

KirillOsenkov added a commit that referenced this issue Apr 13, 2021
@KirillOsenkov
Bring back ProjectStarted.GlobalProperties
d6bf2e7 
Some loggers depended on ProjectStartedEventArgs.GlobalProperties being not null and set. It will take a long time to move them to ProjectEvaluationFinished (needs to bump MSBuild dependency to 16.10).

For now log GlobalProperties in both places (ProjectStarted and ProjectEvaluationFinished). Hopefully the deduplication will save us from any significant increase in binlog size.

Fixes #6341
@KirillOsenkov KirillOsenkov mentioned this issue Apr 13, 2021
Merged
Forgind pushed a commit that referenced this issue Apr 13, 2021
@KirillOsenkov
Bring back ProjectStarted.GlobalProperties (#6342)
8d57dfc 
Some loggers depended on ProjectStartedEventArgs.GlobalProperties being not null and set. It will take a long time to move them to ProjectEvaluationFinished (needs to bump MSBuild dependency to 16.10).

For now log GlobalProperties in both places (ProjectStarted and ProjectEvaluationFinished). Hopefully the deduplication will save us from any significant increase in binlog size.

Fixes #6341
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KirillOsenkov KirillOsenkov

Labels
Area: Logging triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bring back ProjectStarted.GlobalProperties dotnet/msbuild
2 participants
@KirillOsenkov @AR-May