Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow IBuildEngine Extension Point #6183

Closed
benvillalobos opened this issue Feb 23, 2021 · 3 comments · Fixed by #6381
Closed

Allow IBuildEngine Extension Point #6183

benvillalobos opened this issue Feb 23, 2021 · 3 comments · Fixed by #6381
Assignees
Labels
Area: Engine Issues impacting the core execution of targets and tasks. needs-design Requires discussion with the dev team before attempting a fix. triaged

Comments

@benvillalobos
Copy link
Member

Issue tracking discussion that started here: #6174 (comment)

Issue Description

Adding new information the task can access from the build engine is cumbersome. Current process:

  1. Create IBuildEngineX
  2. Add one property
  3. Modify TaskHost and OOPTaskHost to implement the interface.

Potential Path Forward

  1. Create an IBuildEngineX that contains a Dictionary<string, object> where object is serializable.
  2. Mihai suggested an IBE with an abstract class called EngineServices.
@benvillalobos benvillalobos added needs-design Requires discussion with the dev team before attempting a fix. needs-triage Have yet to determine what bucket this goes in. labels Feb 23, 2021
@benvillalobos benvillalobos changed the title Implement IBuildEngine Extension Point Allow IBuildEngine Extension Point Feb 23, 2021
@Forgind
Copy link
Member

Forgind commented Mar 3, 2021

@marcpopMSFT suggested we should put this off until mid-April at the earliest.

@rainersigwald
Copy link
Member

@ladipro you're basically doing this in one of your outstanding PRs right?

@rainersigwald rainersigwald added Area: Engine Issues impacting the core execution of targets and tasks. and removed needs-triage Have yet to determine what bucket this goes in. labels Jun 9, 2021
@ladipro
Copy link
Member

ladipro commented Jun 9, 2021

Affirmative. I wasn't aware of this one, I like the suggested name EngineServices.

@ladipro ladipro self-assigned this Jun 9, 2021
@ladipro ladipro linked a pull request Jun 9, 2021 that will close this issue
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Engine Issues impacting the core execution of targets and tasks. needs-design Requires discussion with the dev team before attempting a fix. triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants