Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExpandPropertiesLeaveEscaped using ReuseableStringBuilder 50% slower than OpportunisticIntern #6063

Closed
arkalyanms opened this issue Jan 22, 2021 · 0 comments · Fixed by #6128
Closed

ExpandPropertiesLeaveEscaped using ReuseableStringBuilder 50% slower than OpportunisticIntern #6063

arkalyanms opened this issue Jan 22, 2021 · 0 comments · Fixed by #6128
Assignees
@ladipro
Labels
performance Performance-Scenario-Solution-Open This issue affects solution open performance. triaged
Projects
Perf sprint Feb 1st - Feb 14th 2021
Milestone
MSBuild 16.10

Comments

@arkalyanms
Copy link
Member

Child of #6034. Traces at "\SLNATSCALE002\CoreVsFramework\Traces\Core_400.etl.zip"

For 400 projects: 2667ms (netcore) vs 1169ms (netframework). Partly addressed in #5663.
@arkalyanms arkalyanms added performance needs-triage Have yet to determine what bucket this goes in. labels Jan 22, 2021
@arkalyanms arkalyanms mentioned this issue Jan 22, 2021
Closed
18 tasks
@AR-May AR-May added Performance-Scenario-Solution-Open This issue affects solution open performance. and removed needs-triage Have yet to determine what bucket this goes in. labels Jan 28, 2021
@ladipro ladipro added this to To Do in Perf sprint Feb 1st - Feb 14th 2021 via automation Feb 1, 2021
@ladipro ladipro self-assigned this Feb 1, 2021
@ladipro ladipro moved this from To Do to In Progress in Perf sprint Feb 1st - Feb 14th 2021 Feb 2, 2021
@ladipro ladipro mentioned this issue Feb 7, 2021
Merged
@ladipro ladipro moved this from In Progress to Done in Perf sprint Feb 1st - Feb 14th 2021 Feb 15, 2021
@ladipro ladipro added this to the MSBuild 16.10 milestone Dec 9, 2021
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ladipro ladipro

Labels
performance Performance-Scenario-Solution-Open This issue affects solution open performance. triaged
Projects
Perf sprint Feb 1st - Feb 14th 2021
Done
Milestone
MSBuild 16.10
Development

Successfully merging a pull request may close this issue.

Optimize property expansion ladipro/msbuild
3 participants
@ladipro @arkalyanms @AR-May