Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DecorateItemsWithMetadata is 3x slower for netcore projects #6062

Closed
Tracked by #6551
arkalyanms opened this issue Jan 22, 2021 · 1 comment · Fixed by #6529
Closed
Tracked by #6551

DecorateItemsWithMetadata is 3x slower for netcore projects #6062

arkalyanms opened this issue Jan 22, 2021 · 1 comment · Fixed by #6529
Assignees
@AR-May
Labels
performance Performance-Scenario-Solution-Open This issue affects solution open performance. Priority:1 Work that is critical for the release, but we could probably ship without size:3 triaged
Projects
Perf sprint Jun 7th - Jun 20th 2021
Milestone
VS 17.0

Comments

@arkalyanms
Copy link
Member

arkalyanms commented Jan 22, 2021 •
edited by ladipro

Child of #6034. Traces at "\\SLNATSCALE002\CoreVsFramework\Traces\Core_400.etl.zip"

For 400 projects: 600ms vs 200ms and increases with projects.
@arkalyanms arkalyanms added performance needs-triage Have yet to determine what bucket this goes in. labels Jan 22, 2021
@arkalyanms arkalyanms mentioned this issue Jan 22, 2021
Closed
18 tasks
@AR-May AR-May added Performance-Scenario-Solution-Open This issue affects solution open performance. and removed needs-triage Have yet to determine what bucket this goes in. labels Jan 28, 2021
@panopticoncentral panopticoncentral added the Priority:1 Work that is critical for the release, but we could probably ship without label Mar 23, 2021
@ladipro ladipro added the size:3 label May 5, 2021
@AR-May AR-May moved this from To Do to In Progress in Perf sprint May 3rd - May 16th 2021 May 12, 2021
@rokonec rokonec removed this from In Progress in Perf sprint May 3rd - May 16th 2021 May 17, 2021
@AR-May
Copy link
Member

AR-May commented Jun 7, 2021

I believe that the reason of this function to be 3 times slower is 3 times more metadata in case of netcore projects. (30,340 vs 11,944 items). I can not see how it could be helped here. We might ask if it is possible to simplify the sdk in this sense.

There are couple of possible minor improvements for this function, I will make a PR for them shortly.

@AR-May AR-May mentioned this issue Jun 7, 2021
Merged
@AR-May AR-May moved this from In Progress to In Review in Perf sprint May 17th - Jun 6th 2021 Jun 7, 2021
@AR-May AR-May removed this from In Review in Perf sprint May 17th - Jun 6th 2021 Jun 7, 2021
@marcpopMSFT marcpopMSFT mentioned this issue Jun 11, 2021
Closed
7 tasks
rainersigwald pushed a commit that referenced this issue Jun 17, 2021
@AR-May
Remove unnecessary list allocations (#6529)
c86ab72 
Fixes #6062
@ladipro ladipro moved this from In Review to Done in Perf sprint Jun 7th - Jun 20th 2021 Jun 21, 2021
@AR-May AR-May mentioned this issue Jul 28, 2021
Closed
@ladipro ladipro added this to the VS 17.0 milestone Dec 9, 2021
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AR-May AR-May

Labels
performance Performance-Scenario-Solution-Open This issue affects solution open performance. Priority:1 Work that is critical for the release, but we could probably ship without size:3 triaged
Projects
Perf sprint Jun 7th - Jun 20th 2021
Done
Milestone
VS 17.0
Development

Successfully merging a pull request may close this issue.

Minor perf fixes for LazyItemEvaluator AR-May/msbuild
4 participants
@panopticoncentral @ladipro @arkalyanms @AR-May