Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Build.Internal.EngineFileUtilities.GetFileListEscaped is 3x slower for netcore projects #6061

Closed
arkalyanms opened this issue Jan 22, 2021 · 2 comments · Fixed by #6227
Closed

Microsoft.Build.Internal.EngineFileUtilities.GetFileListEscaped is 3x slower for netcore projects #6061

arkalyanms opened this issue Jan 22, 2021 · 2 comments · Fixed by #6227
Assignees
@ladipro
Labels
performance Performance-Scenario-Solution-Open This issue affects solution open performance. size:3 triaged
Projects
Perf sprint Mar 1st - Mar 14th 2021
Milestone
VS 17.0

Comments

@arkalyanms
Copy link
Member

Child of #6034. Traces at "\SLNATSCALE002\CoreVsFramework\Traces\Core_400.etl.zip"

For 400 projects it takes 960ms(netcore) vs 320ms(netframework) and the delta increases with project.
@arkalyanms arkalyanms added performance needs-triage Have yet to determine what bucket this goes in. labels Jan 22, 2021
@arkalyanms arkalyanms mentioned this issue Jan 22, 2021
Closed
18 tasks
@AR-May AR-May added Performance-Scenario-Solution-Open This issue affects solution open performance. and removed needs-triage Have yet to determine what bucket this goes in. labels Jan 28, 2021
@ladipro
Copy link
Member

ladipro commented Mar 1, 2021

Likely addressed with #6151, will confirm.

@ladipro ladipro self-assigned this Mar 1, 2021
@ladipro ladipro added the size:3 label Mar 1, 2021
@ladipro ladipro moved this from To Do to In Progress in Perf sprint Mar 1st - Mar 14th 2021 Mar 2, 2021
@ladipro
Copy link
Member

ladipro commented Mar 3, 2021

Acceptance criteria: The cost of GetFileListEscaped is reduced by at least 20%.

@ladipro ladipro mentioned this issue Mar 4, 2021
Merged
@ladipro ladipro moved this from In Progress to In Review in Perf sprint Mar 1st - Mar 14th 2021 Mar 5, 2021
@ladipro ladipro moved this from In Review to Done in Perf sprint Mar 1st - Mar 14th 2021 Mar 11, 2021
@ladipro ladipro added this to the VS 17.0 milestone Dec 9, 2021
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ladipro ladipro

Labels
performance Performance-Scenario-Solution-Open This issue affects solution open performance. size:3 triaged
Projects
Perf sprint Mar 1st - Mar 14th 2021
Done
Milestone
VS 17.0
Development

Successfully merging a pull request may close this issue.

Optimize EngineFileUtilities.GetFileList ladipro/msbuild
3 participants
@ladipro @arkalyanms @AR-May