ExpandPropertiesLeaveTypedAndEscaped (incorrectly) makes the assumption that it's ReuseableStringBuilder won't be resized #4084
Labels
performance
Performance-Scenario-Solution-Open
This issue affects solution open performance.
Priority:2
Work that is important, but not critical for the release
triaged
Milestone
Opening a large 1000 project solution based on a solution with http://github.com/dotnet/project-system's project duplicated many times, I can see that 8.4% of all allocations during solution load (before we OOM) is ExpandPropertiesLeaveTypedAndEscaped expanding its ReuseableStringBuilder:
This seems to indicate that this is not required:
I suspect we're not caching the builder because it's grown too big so the comment will be incorrect. We should set a sensible initial size based on what we're going to put inside it.
The text was updated successfully, but these errors were encountered: