Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Log Task Inputs performance #2200

Closed
KirillOsenkov opened this issue Jun 8, 2017 · 3 comments
Closed

Investigate Log Task Inputs performance #2200

KirillOsenkov opened this issue Jun 8, 2017 · 3 comments
Assignees
Labels
Area: Logging help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. performance Performance-Scenario-Build This issue affects build performance. triaged
Milestone

Comments

@KirillOsenkov
Copy link
Member

The amount of data passed to NuGet tasks is huge, but @nguerrera points out we do unnecessary string concatenation there. Let's investigate builds with /v:diag (that enable log task inputs).

See also:
#2164
#2168

@nguerrera
Copy link
Contributor

I was asked for a brain dump on this. Here's all I have: Loggers are passed the each parameter as one string. If the parameters are items, then all the items and their metadata go together in one string. This can end up on the large object heap and cause perf problems. I would imagine a fix involving streaming the items to the log without concatenating them in to a string.

@KirillOsenkov
Copy link
Member Author

@KirillOsenkov KirillOsenkov self-assigned this Mar 31, 2020
@KirillOsenkov KirillOsenkov added Good First Issue Self-contained issues good for first-time contributors. help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. performance Performance-Scenario-Build This issue affects build performance. labels Mar 31, 2020
@rainersigwald rainersigwald removed the Good First Issue Self-contained issues good for first-time contributors. label Mar 31, 2020
@KirillOsenkov
Copy link
Member Author

This is now fixed by #6155.

@ladipro ladipro added this to the MSBuild 16.10 milestone Dec 9, 2021
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Logging help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. performance Performance-Scenario-Build This issue affects build performance. triaged
Projects
None yet
Development

No branches or pull requests

5 participants