Investigate logs forwarding needs

[JanKrivanek]

Context

Currently the BuildCheckLoggerConnector relies on pre-existing build events forwarding functionality. This works since CentralForwardingLogger is being used for unrecognized loggers - which forwards all the events, plus sets the MinimumRequiredMessageImportance to Low (on additional msbuild nodes)

It however might lead to over-excessive emiting and trnsmission of events, which might have negative impact on perf.

Need to investigate

• What is the perf impact of using the CentralForwardingLogger vs the ConfigurableForwardingLogger with couple basic events - as is being requested by the console log or terminal logger (

  msbuild/src/MSBuild/XMake.cs

  Lines 3796 to 3801 in 47ba51c

  	{
  	ProcessTerminalLogger(noConsoleLogger, aggregatedTerminalLoggerParameters, distributedLoggerRecords, verbosity, cpuCount, loggers);
  	}
  	else
  	{
  	ProcessConsoleLoggerSwitch(noConsoleLogger, consoleLoggerParameters, distributedLoggerRecords, verbosity, cpuCount, loggers);

  )
• Can we use ConfigurableForwardingLogger with enabling the all events (https://github.com/dotnet/msbuild/blob/main/src/Build/Logging/DistributedLoggers/ConfigurableForwardingLogger.cs#L402-L423)

• setting MinimumRequiredMessageImportance to High (in

  msbuild/src/Build/BackEnd/Components/Logging/LoggingService.cs

  Line 1752 in 47ba51c

  private void UpdateMinimumMessageImportance(ILogger logger)

  ) as a stop gap - that will ensure all events are transfered, while MessageImportance.Low messages are not emitted nor transfered from the Tasks

• Can we influence the forwarding even during the build? Currently those seem to be set prior the build starts. But we'll discover the opt-ins, configurations and custom analyzers only during the evaluation of individual projects

References

• https://learn.microsoft.com/en-us/visualstudio/msbuild/creating-forwarding-loggers?view=vs-2022