Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TerminalLogger overwrites "attempting to cancel the build" message #8983

Open
rainersigwald opened this issue Jun 30, 2023 · 0 comments · May be fixed by #10055
Open

TerminalLogger overwrites "attempting to cancel the build" message #8983

rainersigwald opened this issue Jun 30, 2023 · 0 comments · May be fixed by #10055
Assignees
@MichalPavlik
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. triaged
Milestone
VS 17.8

Comments

@rainersigwald
Copy link
Member

When you cancel command-line MSBuild, we send the cancellation signal through the API and also writes status to stdout. But it does so directly:

msbuild/src/MSBuild/XMake.cs

Line 1007 in 39e20dc

Console.WriteLine(ResourceUtilities.GetResourceString("AbortingBuild"));

And terminallogger tends to immediately overwrite that message with status updates, so it's not obvious whether cancellation is in progress.
@rainersigwald rainersigwald added the Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. label Jun 30, 2023
@rainersigwald rainersigwald added this to the VS 17.8 milestone Jun 30, 2023
@rainersigwald rainersigwald mentioned this issue Jun 30, 2023
Merged
@rainersigwald rainersigwald mentioned this issue Jul 13, 2023
Closed
@AR-May AR-May added the triaged label Feb 21, 2024
@MichalPavlik MichalPavlik self-assigned this Mar 20, 2024
@MichalPavlik MichalPavlik linked a pull request Apr 22, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichalPavlik MichalPavlik

Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. triaged
Projects
None yet
Milestone
VS 17.8
Development

Successfully merging a pull request may close this issue.

Rendering message about build cancellation (Terminal Logger) dotnet/msbuild
3 participants
@rainersigwald @MichalPavlik @AR-May