Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzers prototyping - Detect and skip restore (evaluation and execution) #9747

Open
Tracked by #9627
JanKrivanek opened this issue Feb 15, 2024 · 0 comments · May be fixed by #10018
Open
Tracked by #9627

Analyzers prototyping - Detect and skip restore (evaluation and execution) #9747

JanKrivanek opened this issue Feb 15, 2024 · 0 comments · May be fixed by #10018

Comments

@JanKrivanek
Copy link
Member

JanKrivanek commented Feb 15, 2024

Context

#9627

Single build has multiple evaluation phases and extra execution phase to facilitate Restore. Running analyzers during those would be superflous - unnecessary perf burden, plus producing duplicite reports.
There might be cases where analysis during Restore is acutaly wanted - but let's skip such cases for now.

Let's somehow detect that current evaluation/execution is for Restore and defunct analyzers infra during that (or alternatively - let's detect it's for Build and enable only during that).
The detection will probably be needed in 2 places - first in the connector logger (for the analyzers getting data from BuildEventArgs) and in RequestBuilder - for analyzers getting data directly in the evaluating/executing node (this second place is not yet mounted in current analyzers prototype code - so can be skipped now).

image

@JanKrivanek JanKrivanek mentioned this issue Feb 15, 2024
14 tasks
@JanKrivanek JanKrivanek changed the title Detect restore (evaluation and execution) and skip it (but probably not if it's the only target and analysis explicitly requested?) Detect and skip restore (evaluation and execution) Feb 15, 2024
@JanKrivanek JanKrivanek changed the title Detect and skip restore (evaluation and execution) Analyzers prototyping - Detect and skip restore (evaluation and execution) Feb 15, 2024
@maridematte maridematte linked a pull request Apr 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants