Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup WinUI to run window scoped tests in new window #7308

Merged
merged 4 commits into from May 19, 2022

Conversation

PureWeen
Copy link
Member

Description of Change

#7172 broke a few things that assumed the root of a WinUI app would be a Panel. This PR starts the journey of fixing the fall out of those changes. I've logged additional issues for fixing the pending issues so that this PR doesn't gain too much behavior change.

@PureWeen PureWeen requested a review from hartez May 18, 2022 21:42
@PureWeen PureWeen enabled auto-merge (squash) May 18, 2022 22:30
@Eilon Eilon added the area/infrastructure 🏗️ CI, Maestro / Coherency label May 19, 2022
@mattleibow mattleibow added this to the 6.0.3xx-sr1 milestone May 19, 2022
@PureWeen PureWeen merged commit 8356889 into main May 19, 2022
@PureWeen PureWeen deleted the fix_winui_tests_step_1 branch May 19, 2022 19:00
@mattleibow
Copy link
Member

We do have a bit of duplicate code for this and AttachAndRun, but rather have 2 paths that work than 1 that does not. We can clean up later.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants