Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tizen] Update ShellView #7287

Merged
merged 1 commit into from May 19, 2022
Merged

[Tizen] Update ShellView #7287

merged 1 commit into from May 19, 2022

Conversation

shyunMin
Copy link
Contributor

Description of Change

This PR includes below changes to improve Shell implementation for Tizen.

  • Fix an issue that the title is not visible
  • Fix an issue that the FlyoutBehavior.Locked works incorrectly
  • Replace an unnecessary local variables with the const values from ThemeConstants
  • Rename an illegal variable name and remove unnecessary keyword

Issues Fixed

Fixes #

@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jsuarezruiz jsuarezruiz added platform/tizen Samsung Tizen Devices (TV) area/shell 🐢 Shell Navigation, Routes, Tabs, Flyout labels May 18, 2022
@Redth Redth requested a review from PureWeen May 18, 2022 16:23
@Redth Redth added this to the 6.0.3xx-sr1 milestone May 18, 2022
@PureWeen PureWeen merged commit 9cfe038 into dotnet:main May 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

Assignees
No one assigned
Labels
area/shell 🐢 Shell Navigation, Routes, Tabs, Flyout platform/tizen Samsung Tizen Devices (TV)
Projects
None yet
Milestone
6.0-sr1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shyunMin @rmarinho @PureWeen @Redth @jsuarezruiz