New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup cake file, add targets, fix for iOS Pair #7241
Conversation
Love this, my only request is can we have a option that installs workloads, builds the sln and even if there0s erros it still opens VS with sln. sometimes getting to test new maestro bump the api breaks, and when I build it doesn't open vs with the local workloads because the sln failed to build, but I wanted to fix the API on VS, not manually. SO maybe a --force option? |
@rmarinho good point. I feel like just opening VS should always be the default :-) That's the point of the cake script anyway right? If you don't want to open VS then just run cli commands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Probably need verify that the nugets have all the same content after CI is done just to be really sure.
Description of Change
build.cake
AFAIK none of these are currently used. At a later point if we need to re-enable the CG tasks we can add them back in using more current toolsVS
: to procure dotnet, builds maui, opens maui.slnf--clean
argument which will delete the bin/obj folders--sln
argument so you can specify a differentsln
file you want VS to open with the local install of dotnet.--pack
.VS
target will now openVS
regardless of failures in the code. If you want to just see build errors in the CLI then you can run thedotnet-buildtasks
target instead of theVS
targetdotnet-sdk-version.txt
file with the dotnet version. iOS Pair to mac currently needs this so it can download the correct dotnet versionOnce this is merged I'll updated
development.md
because that's probably going to be a bit of a discussion.EXAMPLE
Install dotnet, pack maui, and open external Solution. This is useful for validating a PR against a users Repro
dotnet cake --sln="<download_directory>\MauiApp2\MauiApp2.sln" --target=VS --pack
Install dotnet and open external Solution. This is useful for validating a PR against a users Repro. If you've already packed MAUI and don't want it to run pack again
dotnet cake --sln="<download_directory>\MauiApp2\MauiApp2.sln" --target=VS
Install dotnet, delete all
bin/obj
, open external Solution.dotnet cake --sln="<download_directory>\MauiApp2\MauiApp2.sln" --target=VS --clean