Allow AbsoluteLayout children to auto size when height/width are not proportional #7183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proportional Fixes #6500
jsuarezruiz
added
the
area/layout 🔲
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
mattleibow
approved these changes
May 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When the height/width layout parameters from AbsoluteLayout are set to AutoSize, the current implementation still restricts the child to the width/height of the AbsoluteLayout, rather than allowing it to size itself.
These changes allow the child to size itself.
Note that this will be a behavioral change from Forms, which has had the "not actually auto-sizing" bug for a while. In most situations this will not be noticeable, as the bugged sizing and correct sizing happen to be the same. For situations where the bugged sizing is preferred, it can be be achieved by setting values of 1 for WidthProportional and HeightProportional.
For the moment, the Compatibility version of the AbsoluteLayout retains the old, bugged behavior.
Issues Fixed
Fixes #6500