Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] OnDestroy is currently firing twice #8541

Closed
PureWeen opened this issue Jul 5, 2022 · 1 comment · Fixed by #14799
Closed

[Android] OnDestroy is currently firing twice #8541

PureWeen opened this issue Jul 5, 2022 · 1 comment · Fixed by #14799
Labels
area/lifecycle 🔁 XPlat and Native UIApplicationDelegate/Activity/Window lifecycle events fixed-in-8.0.0-preview.4.8333 Look for this fix in 8.0.0-preview.4.8333! p/1 Work that is critical for the release, but we could probably ship without platform/android 🤖

Comments

@PureWeen
Copy link
Member

PureWeen commented Jul 5, 2022

The following PR tried to fix this issue. I think the PR didn't notice that we already have hooks into calling OnDestroy here. I don't think the original issue is fixable on Android because of the comments that @mattleibow has made here.

OnDestroyed isn't a resilient place to put any of your code

Repro steps

Run the code from the original PR

If you hit the back button to kill your activity or you set your android developer settings to always destroy your activity then you will see it fire twice when you background and the foreground the app

@PureWeen PureWeen added this to the 6.0-sr3 milestone Jul 5, 2022
@PureWeen PureWeen added area/lifecycle 🔁 XPlat and Native UIApplicationDelegate/Activity/Window lifecycle events s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed platform/android 🤖 labels Jul 5, 2022
@samhouts samhouts added the p/1 Work that is critical for the release, but we could probably ship without label Jul 18, 2022
@mattleibow mattleibow modified the milestones: 6.0-sr3, 6.0-servicing Aug 29, 2022
@Redth Redth modified the milestones: 6.0-servicing, Backlog Aug 30, 2022
@ghost
Copy link

ghost commented Aug 30, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@samhouts samhouts modified the milestones: Backlog, .NET 8 Planning Jan 26, 2023
@samhouts samhouts removed s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Apr 5, 2023
@dotnet dotnet locked as resolved and limited conversation to collaborators May 28, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.4.8333 Look for this fix in 8.0.0-preview.4.8333! label Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/lifecycle 🔁 XPlat and Native UIApplicationDelegate/Activity/Window lifecycle events fixed-in-8.0.0-preview.4.8333 Look for this fix in 8.0.0-preview.4.8333! p/1 Work that is critical for the release, but we could probably ship without platform/android 🤖
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants