[Windows] Improve performance of ContentPanel.EnsureBorderPath
#22346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartyIX
commented
May 11, 2024
|
|
||
| _borderPath.UpdatePath(_borderStroke?.Shape, width, height); | ||
| UpdateClip(_borderStroke?.Shape, width, height); | ||
| } | ||
|
|
||
| internal void EnsureBorderPath() | ||
| internal void EnsureBorderPath(bool containsCheck = true) |
There was a problem hiding this comment.
This is the main change.
There was a problem hiding this comment.
Also invoked from
There was a problem hiding this comment.
Yes. I believe one cannot use containsCheck = false there though so I did not do it.
If it is not what you meant, please clarify.
|
Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
MartyIX
changed the title
ContentPanel performanceContentPanel performance regarding EnsureBorderPath
MartyIX
changed the title
ContentPanel performance regarding EnsureBorderPathContentPanel.EnsureBorderPath
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Could you update again the Speedscope comparison screenshot? |
|
Here is the original one:
Or do you mean a new one? |
jsuarezruiz
approved these changes
May 13, 2024
|
|
||
| _borderPath.UpdatePath(_borderStroke?.Shape, width, height); | ||
| UpdateClip(_borderStroke?.Shape, width, height); | ||
| } | ||
|
|
||
| internal void EnsureBorderPath() | ||
| internal void EnsureBorderPath(bool containsCheck = true) |
There was a problem hiding this comment.
Also invoked from
Eilon
added
the
t/perf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR is a simple performance improvement for
ContentPanelon Windows.The main change is in the 3rd commit (5056720), previous commits fix code style.
Performance comparison
Speedscope comparing main and this PR using testing code (main, PR):
How to repeat:
and click
Batch Add Bordersbutton FIVE times.Issues Fixed
Contributes to #21087