Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previously selected item cannot be reselected fix #21490

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Mar 27, 2024

Issues Fixed

Fixes #20273

Before After

@kubaflo kubaflo requested a review from a team as a code owner March 27, 2024 19:22
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Mar 27, 2024
@Eilon Eilon added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Mar 29, 2024
@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

firstItem.Click();
var numberOfNavigations = App.WaitForElement("numberOfNavigations").GetText();

Assert.AreEqual(int.Parse(numberOfNavigations!), 2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
This test is failing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run this again on CI, and seems to keep failing. Will take a look locally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, get the same result
image
Let me know if can help in someway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsuarezruiz, this test if failing only on Windows. I don't have a Windows device to work on this. Can you please have a look at this or maybe we can omit Windows for this issue?

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Previously selected Shellitem cannot be reselected
3 participants