[iOS] Fixed RadioButton text related properties not working #20366
Conversation
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
ghost
added
the
legacy-area-controls
| if (radioButton.Content is string | ||
| && handler.VirtualView.PresentedContent is Element element | ||
| && FindLabel(element) is Label label) | ||
| { |
There was a problem hiding this comment.
With the changes in the Mapper, are not similar changes required on Android as well?
There was a problem hiding this comment.
Android radio buttons work without any changes needed. Therefore, I used the preprocessor directives #if IOS to modify only the iOS's mapper
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
ios-radio-button-text
branch
from
1236fea
to
8ab5220
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Eilon
removed
the
legacy-area-controls
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| // We want to modify the text in the content property only if | ||
| // the content is a string. In that case we want to apply | ||
| // the text values from the radio button | ||
| if (radioButton.Content is string |
There was a problem hiding this comment.
Can we resolve this by adding all these properties to templated bindings?
|
I pulled the latest from main and tested it against your UI Test and it looks like this problem may have already been fixed. See screenshot below: |
|
@dustin-wojciechowski I've also tested it and have the same observations. Therefore, I'm closing this PR |
Description of Change
When the content was set as plain text, the label created based on that text never applied any text properties.
Issues Fixed
Fixes #19081
Screen.Recording.2024-02-05.at.18.55.49.mov