Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Config additions #5933

Merged
merged 1 commit into from Sep 16, 2021
Merged

Conversation

michaelgsharp
Copy link
Member

Re-adds some removed editor config settings that were causing issues with visual studio builds.

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #5933 (c5dda31) into main (6ae2cff) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5933      +/-   ##
==========================================
+ Coverage   68.19%   68.25%   +0.05%     
==========================================
  Files        1142     1142              
  Lines      242367   242367              
  Branches    25355    25355              
==========================================
+ Hits       165287   165419     +132     
+ Misses      70400    70282     -118     
+ Partials     6680     6666      -14     
Flag Coverage Δ
Debug 68.25% <ø> (+0.05%) ⬆️
production 62.94% <ø> (+0.06%) ⬆️
test 88.58% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0.00%> (-20.52%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 25.38% <0.00%> (-1.53%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.38% <0.00%> (+0.14%) ⬆️
...StandardTrainers/Standard/LinearModelParameters.cs 66.07% <0.00%> (+0.25%) ⬆️
src/Microsoft.ML.Data/Utils/LossFunctions.cs 67.35% <0.00%> (+0.51%) ⬆️
...oft.ML.StandardTrainers/Standard/SdcaMulticlass.cs 92.15% <0.00%> (+1.02%) ⬆️
...crosoft.ML.StandardTrainers/Optimizer/Optimizer.cs 73.12% <0.00%> (+1.15%) ⬆️
src/Microsoft.ML.Sweeper/AsyncSweeper.cs 72.78% <0.00%> (+1.36%) ⬆️
test/Microsoft.ML.AutoML.Tests/AutoFitTests.cs 89.04% <0.00%> (+1.96%) ⬆️
...crosoft.ML.StandardTrainers/Standard/SdcaBinary.cs 88.13% <0.00%> (+3.07%) ⬆️
... and 2 more

@michaelgsharp michaelgsharp requested a review from a team September 13, 2021 16:42
@michaelgsharp michaelgsharp merged commit 3bf8cba into dotnet:main Sep 16, 2021
@michaelgsharp michaelgsharp deleted the editor-config-fix branch September 16, 2021 21:15
@dotnet dotnet locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants