Allow developers to supply their own function to infer column data types from data while loading CSVs #7142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7142 +/- ##
==========================================
+ Coverage 68.55% 68.57% +0.01%
==========================================
Files 1259 1259
Lines 255844 255969 +125
Branches 26434 26452 +18
==========================================
+ Hits 175392 175518 +126
- Misses 73717 73718 +1
+ Partials 6735 6733 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…has less columns than the others
This reverts commit 5a2ee30. # Conflicts: # src/Microsoft.Data.Analysis/DataFrame.IO.cs
|
@JakeRadMSFT @luisquintanilla can I get you 2 to take a look at this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7141
Currently when you use
LoadCsvorLoadCsvFromStringwithout supplying data types for each column, the code will try to guess the data types based on the data in the CSV file. This is good, but the problem is that the default type inference code only considersbool,float,DateTime, andstringfor column types. Sometimes the user may need another data type, such asint,long, ordouble(see issue 6347 for an example where someone had a problem with thefloatdata type that was chosen by default) but not know the structure of the data ahead of time.I would like to be able to pass in my own custom type inference logic to override the default
GuessKindimplementation that is given in the library right now. If no custom guess type function is provided to theLoadCsvorLoadCsvFromStringmethods, then the code should work the same as it does today.