Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILLink is no longer crossgen'd #3168

Open
sbomer opened this issue Dec 22, 2022 · 2 comments
Open

ILLink is no longer crossgen'd #3168

sbomer opened this issue Dec 22, 2022 · 2 comments

Comments

@sbomer
Copy link
Member

sbomer commented Dec 22, 2022

With the change to download a linker package that matches the target framework (dotnet/sdk#29441), ILLink is no longer bundled with the SDK and therefore is no longer going to be crossgen'd (see dotnet/installer#15151 (comment)).

Opening this as a tracking issue in case we want to do something about that. Let's keep an eye on the build performance. If we need to, we could probably ship RID-specific ILLink packages that are crossgen'd as part of the runtime build.

@LXGaming
Copy link

Documenting an issue I encountered with GitHub Actions Runner ubuntu22/20231115.7 (includes .NET 8) when building a .NET 7 project.

I use GitHub Actions for publishing trimmed .NET binaries, my workflow consists of a restore step and all subsequent steps use --no-restore, I found that builds were no longer being trimmed due to ILLink having disappeared. I eventually stumbled upon this issue and its linked PRs which noted that a restore would be required for ILLink to be downloaded, because I use /p:PublishTrimmed=true and --no-restore on the publish command ILLink is never downloaded.

The solution is to add /p:PublishTrimmed=true to the restore command or alternatively avoid using --no-restore to ensure that ILLink is present.

I believe there should be a warning or error when PublishTrimmed is specified but ILLink isn't present.

@sbomer
Copy link
Member Author

sbomer commented Nov 20, 2023

Thanks for reporting @LXGaming, let's track that in dotnet/sdk#37049.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants