Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix call to GetIOException (issue 1928) #1932

Merged
merged 1 commit into from Sep 29, 2022
Merged

fix call to GetIOException (issue 1928) #1932

merged 1 commit into from Sep 29, 2022

Conversation

jdbruner
Copy link
Contributor

@jdbruner jdbruner commented Sep 25, 2022 •
edited by ghost

Fixes #1928
As described in the issue, in LibGpiodDriverEventHandler.SubscribeForEvent the last two arguments to GetIOException were reversed.

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-System.Device.Gpio Contains types for using general-purpose I/O (GPIO) pins label Sep 25, 2022
joperezr
joperezr approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@joperezr joperezr merged commit aef8e76 into dotnet:main Sep 29, 2022
@jdbruner jdbruner deleted the issue_1928 branch January 10, 2023 01:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pgrawehr pgrawehr pgrawehr approved these changes

@joperezr joperezr joperezr approved these changes

Assignees
No one assigned
Labels
area-System.Device.Gpio Contains types for using general-purpose I/O (GPIO) pins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LibGpiodDriverEventHandler.SubscribeForEvent calls GetIOException incorrectly
3 participants
@jdbruner @pgrawehr @joperezr