Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConvertToAnonymousRecord quick fixeroony #10493

Merged
merged 6 commits into from Nov 19, 2020

Conversation

cartermp
Copy link
Contributor

A way to ease #8127

And also, in general, help people who forget the extra | when using anonymous records

image

@cartermp cartermp added this to the 16.9 milestone Nov 18, 2020
@cartermp
Copy link
Contributor Author

Note: there is no quick fix for opening a module or namespace that has a record with this "shape". I can try to do that in a separate PR, but it is definitely out of scope of this quick fix. If that gets implemented, it is not exclusive to this quick fix. Both would be suggestions.

Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the comment then you are good to go.

src/fsharp/service/ServiceUntypedParse.fsi Outdated Show resolved Hide resolved
@cartermp cartermp closed this Nov 18, 2020
@cartermp cartermp reopened this Nov 18, 2020
@cartermp cartermp merged commit abd9316 into dotnet:main Nov 19, 2020
@cartermp cartermp deleted the suggest-anon-record branch November 19, 2020 01:59
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants