Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MakeDeclarationMutable code fix #10480

Merged
merged 4 commits into from Nov 18, 2020
Merged

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented Nov 16, 2020

This makes #1110 a bit easier too.

Works where it should work:

image

image

And it does not trigger if the value is a parameter binding, which would be invalid F# syntax:

image

The above shows in the status bar if you try it for code like this:

type C() =
    member _.M(x: int) =
        x <- 1

let f (x: int) =
    x <- 1
    x

@cartermp cartermp added this to the 16.9 milestone Nov 17, 2020
@cartermp cartermp merged commit 31cb3b3 into dotnet:main Nov 18, 2020
@cartermp cartermp deleted the make-decl-mutable branch November 18, 2020 22:00
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants