Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion list appears to treat digit/underscore in identifier as a boundary #6134

Closed
chadunit opened this issue Jan 18, 2019 · 2 comments
Closed

Completion list appears to treat digit/underscore in identifier as a boundary #6134

chadunit opened this issue Jan 18, 2019 · 2 comments
Labels
Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Milestone
16.9

Comments

@chadunit
Copy link

chadunit commented Jan 18, 2019 •
edited

Completion list invoked after a digit only searches on the characters after the digit, and upon accepting a suggestion it inserts the suggestion after the digit resulting in duplicated characters.

EDIT: Also happens with underscore.

(Note Show completion list after a character is typed is disabled, and completion list is manually summoned via Ctrl+Space.)

vs completion digit

Expected behavior

Completion invoked on UTF8E should search for UTF8E, and entire identifier should be updated when accepting suggestion.

Actual behavior

Completion invoked on UTF8E only searches for E, and accepting the suggestion only applies it to the portion after the digit.

Related information

Visual Studio Community 2017 15.9.4
Visual F# Tools nightly 15.8.20181217.1
.NET Core SDK 2.2.101
@cartermp cartermp added this to the 16.0 milestone Jan 18, 2019
@chadunit chadunit changed the title Completion list appears to treat digit in identifier as a boundary Completion list appears to treat digit/underscore in identifier as a boundary Jan 21, 2019
@cartermp cartermp modified the milestones: 16.0, 16.1 Feb 21, 2019
@cartermp cartermp mentioned this issue Apr 10, 2019
Open
4 tasks
@cartermp cartermp modified the milestones: 16.1, 16.2 Apr 23, 2019
@cartermp cartermp modified the milestones: 16.2, Backlog Apr 30, 2019
@dsyme dsyme added the Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. label Aug 26, 2020
@dsyme
Copy link
Contributor

dsyme commented Aug 26, 2020

I've noticed this, there is definitely something quirky mis-interpreting identifier status. We should remove this glitch

@zanaptak zanaptak mentioned this issue Nov 19, 2020
Merged
@cartermp
Copy link
Contributor

This should be addressed by #10500

@cartermp cartermp modified the milestones: Backlog, 16.9 Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Projects
None yet
Milestone
16.9
Development

No branches or pull requests
3 participants
@cartermp @dsyme @chadunit