Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to feature/nullness #17097

Open
wants to merge 7 commits into
base: feature/nullness
Choose a base branch
from

Conversation

dotnet-bot
Copy link
Contributor

This is an automatically generated pull request from main into feature/nullness.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/main-to-feature/nullness
git reset --hard upstream/feature/nullness
git merge upstream/main
# Fix merge conflicts
git commit
git push upstream merges/main-to-feature/nullness --force

TheAngryByrd and others added 6 commits April 25, 2024 13:53
…17085)

#17082

Co-authored-by: Petr <psfinaki@users.noreply.github.com>
* Remove some dead code

* Fix

* Remove unnecessary fn

* oops
#16857)

* Generate new Equals overload to avoid boxing for structural comparison

* More benchmarks

---------

Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
)

* Allow AttributeTargets.Field and .Property for type let bindings

* Fixed tests which involved fields+functions

---------

Co-authored-by: Petr <psfinaki@users.noreply.github.com>
* Add volatile to valueFactory

* reformat

---------

Co-authored-by: Petr <psfinaki@users.noreply.github.com>
* corebeforeafter

* depends

* temp

* temp

* tweak

* tweak

* typo
@dotnet-bot
Copy link
Contributor Author

⚠ This PR has merge conflicts. @T-Gro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

None yet

7 participants