Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments get decolorized in some newly created projects #16886

Open
psfinaki opened this issue Mar 18, 2024 · 6 comments
Open

Comments get decolorized in some newly created projects #16886

psfinaki opened this issue Mar 18, 2024 · 6 comments
Labels
Area-VS-Editor VS editor support for F# code, not covered elsewhere Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Milestone

Comments

@psfinaki
Copy link
Member

psfinaki commented Mar 18, 2024

Repro steps

  1. First create a new F# Console App
  2. Then create a new F# Console Application(.NET Framework)
  3. Observe Program.fs

Expected behavior

All good, nothing special happens.

Actual behavior

In a few minutes, comments go gray:

945492ac-8132-4236-8f8c-60555a282950

Known workarounds

Start editing the doc, things go back to normal.

Related information

17.10.0 Preview 3.0 [34714.165.main], X64 and ARM64.

@github-actions github-actions bot added this to the Backlog milestone Mar 18, 2024
@psfinaki
Copy link
Member Author

The ticket above in a copy from an internal backlog, we cannot repro this fully yet, but I can see something similar (colors disappearing right away without a few minutes' lag):

Recording.2024-03-15.181748.mp4

@psfinaki
Copy link
Member Author

Need to see if it's even an F# thing. Not many templates have comments there right away, so it's not clear yet.

@vzarytovskii
Copy link
Member

I know Petr P. had the same issue sometimes in his setup, but I didn't and we never figured out. Right now colouring (roughly) work as follows:

  1. Roslyn asks us about both syntactic and semantic highlighting for specific ranges in document
  2. We just return what's on these ranges
  3. Roslyn/vs colours it.

What I suspect can be happening:
a. We return incorrect type for some range at some point for some reason.
b. Roslyn or some other "extension" for some reason resets it at some point.
c. There's some weird set of dogfood options for some accounts which reset colouring settings themselves for a brief period.

I don't see any other semantic colouring broken in the repros, as well as it's reported, that only new projects are affected, it's not critical, but we better investigate it since it can (theoretically) be affecting something else.

@majocha
Copy link
Contributor

majocha commented Mar 18, 2024

FWIW I've seen this quite often at some point when opening existing slns, but not recently. The only classification affected was the comment, everything else was normal, so I assumed it's some bug on VS side.

@vzarytovskii
Copy link
Member

so I assumed it's some bug on VS side.

Yeah, that what I was thinking as well. I have never seen it in my setup. Like not a single time :)

@majocha
Copy link
Contributor

majocha commented Mar 18, 2024

Oops, just right now. Opening FSharp.sln with some preopened documents.
image

This is clearly the default plain text classifictation. Only the current document is affected when opening VS. The rest look fine. As soon as I do some edit in the file it gets back to normal. So this is minimal impact IMV.

Should look like this in my case:

image

@abonie abonie added Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. Area-VS-Editor VS editor support for F# code, not covered elsewhere and removed Needs-Triage labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-VS-Editor VS editor support for F# code, not covered elsewhere Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Projects
Status: New
Development

No branches or pull requests

4 participants