Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltips: different classification for interface and override properties #10418

Closed
auduchinok opened this issue Nov 10, 2020 · 5 comments · Fixed by #9563
Closed

Tooltips: different classification for interface and override properties #10418

auduchinok opened this issue Nov 10, 2020 · 5 comments · Fixed by #9563
Labels
Area-FCS Bug
Milestone
16.9

Comments

@auduchinok
Copy link
Member 

type T() =
    interface System.IDisposable with
        member x.Dispose() = ()

Screenshot 2020-11-10 at 18 16 37
@cartermp cartermp added this to the Backlog milestone Nov 11, 2020
@En3Tho
Copy link
Contributor

En3Tho commented Nov 12, 2020 •
edited

I believe this must be fixed by #9563 because member methods are colorized as values by default (same with let functions)
Any change of it being merged in some not so distant future?
@cartermp

@En3Tho
Copy link
Contributor

En3Tho commented Nov 12, 2020 •
edited

By the way, I think I've found a bug too (submitted in #10441):
image
"x" variable name isn't mentioned anywhere in a tooltip for some reason when "x" is a tuple
@cartermp

@cartermp
Copy link
Contributor

Any change of it being merged in some not so distant future?

First steps is to fix conflicts and get an update to tests. After that I just need someone to review it

@cartermp
Copy link
Contributor

Yeah I think the coloring is fixed in VS at least, I would expect Rider's color to also get fixed with #9563

image

@cartermp cartermp linked a pull request Nov 13, 2020 that will close this issue
Tag items in tooltips consistenly with respect to document classification (such colors, much wow) #9563
Merged
@En3Tho
Copy link
Contributor

En3Tho commented Nov 15, 2020

Looks very nice :)

@cartermp cartermp modified the milestones: Backlog, 16.9 Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-FCS Bug
Projects
None yet
Milestone
16.9
3 participants
@auduchinok @cartermp @En3Tho