The logging source generator emits `CS0757` errors when referencing `Microsoft.Extensions.Resilience` #4969

ZzZombo · 2024-02-26T10:24:45Z

Description

Reproduction Steps

A new WPF application targeting .NET 8, using the following packages:

 		<PackageReference Include="Microsoft.Extensions.Configuration.UserSecrets" Version="8.0.0" />
		<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
		<PackageReference Include="Microsoft.Extensions.Hosting" Version="8.0.0" />
		<PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.0" />
		<PackageReference Include="Microsoft.Extensions.Options" Version="8.0.2" />
		<PackageReference Include="Microsoft.Extensions.Resilience" Version="8.2.0" />

Expected behavior

No error.

Actual behavior

Severity	Code	Description	Project	File	Line	Suppression State
Error	CS0757	A partial method may not have multiple implementing declarations	Program	G:\home\dev\csharp\temp\src\Microsoft.Extensions.Logging.Generators\Microsoft.Extensions.Logging.Generators.LoggerMessageGenerator\LoggerMessage.g.cs	13	Active

Regression?

Known Workarounds

None barring not using the package.

Configuration

.NET SDK:
Version: 8.0.200
Commit: 438cab6a9d
Workload version: 8.0.200-manifests.e575128c

Runtime Environment:
OS Name: Windows
OS Version: 10.0.19045
OS Platform: Windows
RID: win-x64
Base Path: C:\Program Files\dotnet\sdk\8.0.200\

.NET workloads installed:
[maui-windows]
Installation Source: VS 17.9.34616.47
Manifest Version: 8.0.6/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.maui\8.0.6\WorkloadManifest.json
Install Type: FileBased

[android]
Installation Source: VS 17.9.34616.47
Manifest Version: 34.0.52/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.android\34.0.52\WorkloadManifest.json
Install Type: FileBased

[ios]
Installation Source: VS 17.9.34616.47
Manifest Version: 17.2.8004/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.ios\17.2.8004\WorkloadManifest.json
Install Type: FileBased

[maccatalyst]
Installation Source: VS 17.9.34616.47
Manifest Version: 17.2.8004/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.maccatalyst\17.2.8004\WorkloadManifest.json
Install Type: FileBased

Host:
Version: 8.0.2
Architecture: x64
Commit: 1381d5ebd2

.NET SDKs installed:
8.0.200 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
Microsoft.AspNetCore.App 6.0.27 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 7.0.16 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.16 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.27 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 7.0.16 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 6.0.27 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 7.0.16 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 8.0.2 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
x86 [C:\Program Files (x86)\dotnet]
registered at [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x86\InstallLocation]

Environment variables:
Not set

global.json file:
Not found

Other information

No response

The text was updated successfully, but these errors were encountered:

ZzZombo · 2024-02-28T11:43:32Z

Could somebody at least point to a workaround? This is a blocking issue for us.

RussKie · 2024-02-29T09:45:44Z

There's a conflict of packages similar to the issues that you've already found.

AFAIK, Microsoft.Extensions.Telemetry.Abstractions carries a source generator that replaces a source generator from Microsoft.Extensions.Logging.Generators, and it's doing so via
<DisableMicrosoftExtensionsLoggingSourceGenerator>true</DisableMicrosoftExtensionsLoggingSourceGenerator> MSBuild property.

extensions/src/Libraries/Microsoft.Extensions.Telemetry.Abstractions/buildTransitive/net6.0/Microsoft.Extensions.Telemetry.Abstractions.props

Lines 2 to 5 in 88d79f7

    
           <!-- This package should replace the Microsoft.Extensions.Logging.Abstractions source generator, so we set the property to remove the source generator from the project. --> 
        
           <PropertyGroup> 
        
             <DisableMicrosoftExtensionsLoggingSourceGenerator>true</DisableMicrosoftExtensionsLoggingSourceGenerator> 
        
           </PropertyGroup>

extensions/src/Libraries/Microsoft.Extensions.Telemetry.Abstractions/buildTransitive/net6.0/Microsoft.Extensions.Telemetry.Abstractions.targets

Lines 2 to 15 in 88d79f7

    
             <!-- This package should replace the Microsoft.Extensions.Logging.Abstractions source generator. --> 
        
             <Target Name="_Microsoft_Extensions_Logging_AbstractionsRemoveAnalyzers"  
        
                     Condition="'$(DisableMicrosoftExtensionsLoggingSourceGenerator)' == 'true'" 
        
                     AfterTargets="ResolveReferences"> 
        
               <ItemGroup> 
        
                 <_Microsoft_Extensions_Logging_AbstractionsAnalyzer Include="@(Analyzer)" Condition="'%(Analyzer.AssemblyName)' == 'Microsoft.Extensions.Logging.Generators' Or 
        
                                                                                                      '%(Analyzer.NuGetPackageId)' == 'Microsoft.Extensions.Logging.Abstractions'" /> 
        
               </ItemGroup> 
        
               <!-- Remove Microsoft.Extensions.Logging.Abstractions Analyzer --> 
        
               <ItemGroup> 
        
                 <Analyzer Remove="@(_Microsoft_Extensions_Logging_AbstractionsAnalyzer)" /> 
        
               </ItemGroup> 
        
             </Target>

Can you verify Microsoft.Extensions.Telemetry.Abstractions is being referenced by your project? And _Microsoft_Extensions_Logging_AbstractionsRemoveAnalyzers is being executed?

ZzZombo · 2024-02-29T10:28:41Z

Can you verify Microsoft.Extensions.Telemetry.Abstractions is being referenced by your project?

Directly or transitively?

And _Microsoft_Extensions_Logging_AbstractionsRemoveAnalyzers is being executed?

Can you explain to me how to do this part?

RussKie · 2024-03-01T00:30:28Z

The easiest way to do both of those is to capture and inspect a binary log. Please see https://msbuildlog.com/ for more information.

Perhaps, try referencing Microsoft.Extensions.Telemetry.Abstractions directly?

ZzZombo · 2024-03-01T01:50:54Z

Adding the package directly had no effect. For other answers please see the screenshot.

RussKie · 2024-03-01T05:42:13Z

You mentioned that your project is targeting net8.0-windows but the screenshot is showing you're consuming net9 packages... Could you please clarify why?

ZzZombo · 2024-03-01T07:22:06Z

You mentioned that your project is targeting net8.0-windows but the screenshot is showing you're consuming net9 packages... Could you please clarify why?

It was to see if doing so fixes this issue. Previously I targeted .NET 8.

xakep139 · 2024-03-07T17:59:24Z

Hello @ZzZombo, I was just trying to reproduce the issue but had no luck:

Are there any specific steps I also need to take? I'm using .NET SDK 8.0.200 as you mentioned in the post and also tried to repro with the .NET CLI, but it still builds the project just fine:

ZzZombo · 2024-03-12T11:27:17Z

@xakep139: this is stripped down project file that still shows the problem for us:

<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk">
	<PropertyGroup Label="General build">
		<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
		<Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
		<TargetFramework>net8.0-windows</TargetFramework>
		<PlatformTarget>AnyCPU</PlatformTarget>
		<OutputType>WinExe</OutputType>
		<ProjectGuid>{<snip/>}</ProjectGuid>
		<ProjectTypeGuids>{60dc8134-eba5-43b8-bcc9-bb4bc16c2548};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
		<AssemblyName>Program</AssemblyName>
		<FileAlignment>512</FileAlignment>
		<WarningLevel>4</WarningLevel>
		<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
		<Deterministic>true</Deterministic>
		<UseWPF>true</UseWPF>
		<UseWindowsForms>False</UseWindowsForms>
		<StartupObject>Company.App</StartupObject>
		<NeutralLanguage>en-US</NeutralLanguage>
		<UserSecretsId><snip/></UserSecretsId>
		<MSBuildCopyContentTransitively>true</MSBuildCopyContentTransitively>
		<EnableConfigurationBindingGenerator>false</EnableConfigurationBindingGenerator>
		<JsonSerializerIsReflectionEnabledByDefault>false</JsonSerializerIsReflectionEnabledByDefault>
	</PropertyGroup>
	<PropertyGroup Condition="'$(Platform)' == 'AnyCPU' ">
		<DefineConstants>TRACE;$(DefineConstants)</DefineConstants>
		<ErrorReport>prompt</ErrorReport>
		<WarningLevel>4</WarningLevel>
	</PropertyGroup>
	<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
		<DebugSymbols>true</DebugSymbols>
		<DebugType>full</DebugType>
		<Optimize>false</Optimize>
		<DefineConstants>DEBUG;$(DefineConstants)</DefineConstants>
	</PropertyGroup>
	<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
		<DebugType>pdbonly</DebugType>
		<Optimize>true</Optimize>
	</PropertyGroup>
	<PropertyGroup Label="General code">
		<LangVersion>12</LangVersion>
		<RootNamespace>Company</RootNamespace>
		<Nullable>enable</Nullable>
		<EnforceCodeStyleInBuild>True</EnforceCodeStyleInBuild>
	</PropertyGroup>
	<ItemGroup Label="Generic Host/DI/Services">
		<PackageReference Include="Microsoft.Extensions.Configuration.UserSecrets" Version="9.0.0-preview.1.24080.9" />
		<PackageReference Include="Microsoft.Extensions.Configuration.Xml" Version="9.0.0-preview.1.24080.9" />
		<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="9.0.0-preview.1.24080.9" />
		<PackageReference Include="Microsoft.Extensions.Localization" Version="8.0.2" />
		<PackageReference Include="Microsoft.Extensions.Hosting" Version="9.0.0-preview.1.24080.9" />
		<PackageReference Include="Microsoft.Extensions.Logging" Version="9.0.0-preview.1.24080.9" />
		<PackageReference Include="Microsoft.Extensions.Options" Version="9.0.0-preview.1.24080.9" />
		<PackageReference Include="Microsoft.Extensions.Resilience" Version="9.0.0-preview.1.24108.1" />
		<PackageReference Include="NReco.Logging.File" Version="1.2.0" />
	</ItemGroup>
</Project>

xakep139 · 2024-03-12T15:00:52Z

Okay, you missed the usage of [LoggerMessage] in your reproduction steps.
Here's the minimal repro:

<Project Sdk="Microsoft.NET.Sdk">
	<PropertyGroup>
		<TargetFramework>net8.0-windows</TargetFramework>
		<OutputType>WinExe</OutputType>
		<UseWPF>true</UseWPF>
	</PropertyGroup>
	<ItemGroup>
		<PackageReference Include="Microsoft.Extensions.Resilience" Version="8.0.0" />
	</ItemGroup>
</Project>

And Log.cs:

using Microsoft.Extensions.Logging;

internal static partial class Log
{
	[LoggerMessage(Level = LogLevel.Information, Message = "Message")]
	public static partial void LogInformation(ILogger logger);
}

xakep139 · 2024-03-12T15:05:52Z

Even if I replace Microsoft.Extensions.Resilience reference with Microsoft.Extensions.Telemetry.Abstractions package, it still emits the same error

RussKie · 2024-03-19T00:30:53Z

I've run some local tests and wonder why we we didn't implement the target this way:

--- a/src/Libraries/Microsoft.Extensions.Telemetry.Abstractions/buildTransitive/net8.0/Microsoft.Extensions.Telemetry.Abstractions.targets
+++ b/src/Libraries/Microsoft.Extensions.Telemetry.Abstractions/buildTransitive/net8.0/Microsoft.Extensions.Telemetry.Abstractions.targets
@@ -2,10 +2,10 @@
   <!-- This package should replace the Microsoft.Extensions.Logging.Abstractions source generator. -->
   <Target Name="_Microsoft_Extensions_Logging_AbstractionsRemoveAnalyzers" 
           Condition="'$(DisableMicrosoftExtensionsLoggingSourceGenerator)' == 'true'"
-          AfterTargets="ResolveReferences">
+          AfterTargets="RemoveDuplicateAnalyzers">
     <ItemGroup>
-      <_Microsoft_Extensions_Logging_AbstractionsAnalyzer Include="@(Analyzer)" Condition="'%(Analyzer.AssemblyName)' == 'Microsoft.Extensions.Logging.Generators' Or
-                                                                                           '%(Analyzer.NuGetPackageId)' == 'Microsoft.Extensions.Logging.Abstractions'" />
+      <_Microsoft_Extensions_Logging_AbstractionsAnalyzer Include="@(Analyzer)" Condition="'%(Analyzer.Filename)' == 'Microsoft.Extensions.Logging.Generators' Or
+                                                                                           '%(Analyzer.Filename)' == 'Microsoft.Extensions.Logging.Abstractions'" />
     </ItemGroup>
 
     <!-- Remove Microsoft.Extensions.Logging.Abstractions Analyzer -->

This way I was able to build a WPF sample without any additional changes.

@joperezr any thoughts?

RussKie · 2024-03-29T02:49:19Z

@joperezr gentle nudge

xakep139 · 2024-04-10T11:07:42Z

@RussKie, will your target also work on non-WPF projects?

RussKie · 2024-04-10T22:12:07Z

will your target also work on non-WPF projects?

It should work universally. More tests will be required to confirm.
I'm still waiting on @joperezr (we've been busy with other high prio work), but we've aiming to have a resolution for this issue for the .5 release.

xakep139 · 2024-05-15T14:41:01Z

It should work universally.

@RussKie my concern was that RemoveDuplicateAnalyzers target might exist for WPF apps only

RussKie · 2024-05-17T02:23:13Z

It should work universally.

my concern was that RemoveDuplicateAnalyzers target might exist for WPF apps only

Yes, you're right. That target is part of the Windows Desktop SDK:

RussKie · 2024-05-17T02:41:59Z

This should work:

  <Target Name="_Microsoft_Extensions_Logging_AbstractionsRemoveAnalyzers" 
          Condition="'$(DisableMicrosoftExtensionsLoggingSourceGenerator)' == 'true'"
-         AfterTargets="ResolveReferences">
+         BeforeTargets="CoreCompile">

Tested for a console app, webapi app and for a WPF apps.

ZzZombo added bug This issue describes a behavior which is not expected - a bug. untriaged labels Feb 26, 2024

RussKie added area-telemetry waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. and removed untriaged labels Feb 29, 2024

dotnet-policy-service bot removed the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Feb 29, 2024

xakep139 linked a pull request Mar 12, 2024 that will close this issue

Fix logging source-gens duplication on WPF #5024

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The logging source generator emits `CS0757` errors when referencing `Microsoft.Extensions.Resilience` #4969

The logging source generator emits `CS0757` errors when referencing `Microsoft.Extensions.Resilience` #4969

ZzZombo commented Feb 26, 2024 •

edited

ZzZombo commented Feb 28, 2024

RussKie commented Feb 29, 2024

ZzZombo commented Feb 29, 2024

RussKie commented Mar 1, 2024

ZzZombo commented Mar 1, 2024

RussKie commented Mar 1, 2024

ZzZombo commented Mar 1, 2024 •

edited

xakep139 commented Mar 7, 2024

ZzZombo commented Mar 12, 2024

xakep139 commented Mar 12, 2024 •

edited

xakep139 commented Mar 12, 2024

RussKie commented Mar 19, 2024

RussKie commented Mar 29, 2024

xakep139 commented Apr 10, 2024

RussKie commented Apr 10, 2024

xakep139 commented May 15, 2024

RussKie commented May 17, 2024

RussKie commented May 17, 2024

The logging source generator emits CS0757 errors when referencing Microsoft.Extensions.Resilience #4969

The logging source generator emits CS0757 errors when referencing Microsoft.Extensions.Resilience #4969

Comments

ZzZombo commented Feb 26, 2024 • edited

Description

Reproduction Steps

Expected behavior

Actual behavior

Regression?

Known Workarounds

Configuration

Other information

ZzZombo commented Feb 28, 2024

RussKie commented Feb 29, 2024

ZzZombo commented Feb 29, 2024

RussKie commented Mar 1, 2024

ZzZombo commented Mar 1, 2024

RussKie commented Mar 1, 2024

ZzZombo commented Mar 1, 2024 • edited

xakep139 commented Mar 7, 2024

ZzZombo commented Mar 12, 2024

xakep139 commented Mar 12, 2024 • edited

xakep139 commented Mar 12, 2024

RussKie commented Mar 19, 2024

RussKie commented Mar 29, 2024

xakep139 commented Apr 10, 2024

RussKie commented Apr 10, 2024

xakep139 commented May 15, 2024

RussKie commented May 17, 2024

RussKie commented May 17, 2024

The logging source generator emits `CS0757` errors when referencing `Microsoft.Extensions.Resilience` #4969

The logging source generator emits `CS0757` errors when referencing `Microsoft.Extensions.Resilience` #4969

ZzZombo commented Feb 26, 2024 •

edited

ZzZombo commented Mar 1, 2024 •

edited

xakep139 commented Mar 12, 2024 •

edited