[release/7.0] Fix SQL Server result mapping for bulk insert (#29565) #29590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#29502 (cherry picked from commit a066241)
AndriySvyryd
approved these changes
Nov 16, 2022
roji
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29502, backports #29565
Description
When reading generated columns back in SaveChanges, the SQL Server logic for matching returned rows back to entities was incorrect for some cases of bulk insertion.
Customer impact
When inserting rows into the same table in SQL Server within the same SaveChanges, an exception could occur, or possibly incorrect propagation of database-generated values.
How found
Customer reported on 7.0
Regression
Yes.
Testing
Added a test for the affected scenario.
Risk
Low; the fix is quite trivial, and a quirk was added to revert back to older behavior.