Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TagWith for ExecuteUpdate and DeleteUpdate #28690

Closed
julielerman opened this issue Aug 12, 2022 · 0 comments
Closed

Implement TagWith for ExecuteUpdate and DeleteUpdate #28690

julielerman opened this issue Aug 12, 2022 · 0 comments
Assignees
Labels
area-bulkcud area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Milestone

Comments

@julielerman
Copy link

I'm currently using:
EF COre 7.0.0-rc.1.22410.9,
.NET 7.0.100-preview.7.22377.5
Visual Studio Version 17.2.3

TagWith compiles when composed with ExecuteUpdate and DeleteUpdate methods:

context.People.Where(p => p.LastName == "Lehrman").TagWith("BulkUpdate")
    .ExecuteUpdate(s => s.SetProperty(c => c.LastName, c => "Lerman"));

... but doesn't put the comment into the SQL.
Log:

info: 8/12/2022 10:31:32.136 RelationalEventId.CommandExecuted[20101] (Microsoft.EntityFrameworkCore.Database.Command)
      Executed DbCommand (11ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
      UPDATE [p]
          SET [p].[LastName] = N'Lerman'
      FROM [People] AS [p]
      WHERE [p].[LastName] = N'Lehrman'
@ajcvickers ajcvickers added this to the 7.0.0 milestone Aug 16, 2022
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 18, 2022
smitpatel added a commit that referenced this issue Aug 18, 2022
smitpatel added a commit that referenced this issue Aug 19, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-rc2 Aug 22, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-rc2, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-bulkcud area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Projects
None yet
Development

No branches or pull requests

3 participants