Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MigrationBuilder.InsertData not considering column types passed in #23503

Closed
fearhq opened this issue Nov 26, 2020 · 2 comments
Closed

MigrationBuilder.InsertData not considering column types passed in #23503

fearhq opened this issue Nov 26, 2020 · 2 comments
Labels
area-migrations-seeding customer-reported Servicing-approved type-bug
Milestone
5.0.3

Comments

@fearhq
Copy link

fearhq commented Nov 26, 2020

EF Core version: 5.0.0
Database provider: Microsoft.EntityFrameworkCore.SqlServer
Target framework: netcoreapp3.1
Operating system: Windows 10
IDE: N/A

When using MigrationBuilder.InsertData to work on a table that has no EF mappings, MigrationBuilder.InsertData does not take into account the columnTypes that are passed in
@fearhq
Copy link
Author

fearhq commented Nov 26, 2020

I mentionned in the PR that added the columnType overloads that for InsertData the value was simply ignored
#22346

@ajcvickers ajcvickers added this to the 5.0.2 milestone Dec 4, 2020
@AndriySvyryd AndriySvyryd removed their assignment Dec 8, 2020
AndriySvyryd added a commit that referenced this issue Dec 8, 2020
@AndriySvyryd
Flow through the column types in MigrationBuilder.InsertData
f9d55d1 
Fixes #23503
@AndriySvyryd AndriySvyryd mentioned this issue Dec 8, 2020
Merged
AndriySvyryd added a commit that referenced this issue Dec 8, 2020
@AndriySvyryd
Add quirk mode for #23503
d8ab3a3
@AndriySvyryd
Copy link
Member

Vote 👍 on the first comment if you are also experiencing this issue.

@smitpatel smitpatel removed this from the 5.0.2 milestone Dec 9, 2020
@AndriySvyryd AndriySvyryd mentioned this issue Dec 12, 2020
Closed
@ajcvickers ajcvickers added this to the 5.0.3 milestone Dec 15, 2020
AndriySvyryd added a commit that referenced this issue Dec 15, 2020
@AndriySvyryd
Flow through the column types in MigrationBuilder.InsertData
401eb06 
Fixes #23503
AndriySvyryd added a commit that referenced this issue Dec 15, 2020
@AndriySvyryd
Add quirk mode for #23503
410c551
@AndriySvyryd AndriySvyryd mentioned this issue Feb 5, 2021
Closed
This was referenced Mar 6, 2021
Closed
Closed
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@AndriySvyryd AndriySvyryd removed their assignment Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-migrations-seeding customer-reported Servicing-approved type-bug
Projects
None yet
Milestone
5.0.3
Development

No branches or pull requests
4 participants
@fearhq @ajcvickers @smitpatel @AndriySvyryd