Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use manifest.json to determine which tests to run. #5337

Open
lbussell opened this issue Apr 5, 2024 · 1 comment
Open

Use manifest.json to determine which tests to run. #5337

lbussell opened this issue Apr 5, 2024 · 1 comment

Comments

@lbussell
Copy link
Contributor

lbussell commented Apr 5, 2024

Describe the Problem

Maintaining TestData.cs causes merge conflicts during servicing and allows for human error. Most of this data is already duplicated in some way by the manifest.json file. We should consider using that file to drive our tests.

Describe the Solution

There is already a model for the manifest in the ImageBuilder tool. We could either duplicate that model, create a simpler model in this repo just for reading the manifest, or factor out the model from ImageBuilder and publish it as a package.

Including a model to read the manifest file in this repo would also help with #4704.

Additional Context

  • Should still allow for disabling specific image tests for certain cases.
@lbussell
Copy link
Contributor Author

[Triage]

  1. We discussed generating the TestData in the Test project, but decided against it since it might be easy to miss special cases that exist in the manifest if the test cases aren't explicitly enumerated.

It would be a good idea to create a prototype of this, probably by creating a simple model in the Test project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant