Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uri paths with non-Ascii chars on Unix changed in 5.0 #19965

Closed
MihaZupan opened this issue Aug 11, 2020 · 0 comments · Fixed by #20144
Closed

Uri paths with non-Ascii chars on Unix changed in 5.0 #19965

MihaZupan opened this issue Aug 11, 2020 · 0 comments · Fixed by #20144
Assignees
@gewarren
Labels
breaking-change Indicates a .NET Core breaking change 🏁 Release: .NET 5 Work items for the .NET 5 release doc-idea Indicates issues that are suggestions for new topics [org][type][category]

Comments

@MihaZupan
Copy link
Member

Uri paths with non-Ascii chars on Unix changed in 5.0

Absolute Unix file paths that contained non-Ascii characters were parsed incorrectly on Unix systems, resulting in duplications in the output. Fixed in dotnet/runtime#36429

Version introduced

Net 5.0

Old behavior

new Uri("/üri")

AbsoluteUri: "/%C3%BCri/%C3%BCri" // Note the additional "/%C3%BCri" at the end
ToString: "/üri/üri" // Note the additinal "/üri" at the end

New behavior

new Uri("/üri")

AbsoluteUri: "/%C3%BCri"
ToString: "/üri"

Reason for change

  • Previous behavior was a bug and made no sense

Recommended action

  • Document the change

Category

  • Core .NET libraries

Affected APIs

All properties on Uris containing absolute Unix paths with non-Ascii characters on Unix systems.

Issue metadata

  • Issue type: breaking-change
@dotnet-bot dotnet-bot added ⌚ Not Triaged Not triaged breaking-change Indicates a .NET Core breaking change labels Aug 11, 2020
@gewarren gewarren added 🏁 Release: .NET 5 Work items for the .NET 5 release doc-idea Indicates issues that are suggestions for new topics [org][type][category] and removed ⌚ Not Triaged Not triaged labels Aug 11, 2020
@gewarren gewarren self-assigned this Aug 11, 2020
gewarren added a commit to gewarren/docs that referenced this issue Aug 17, 2020
@gewarren
Fixes dotnet#19965
3c6366a
@gewarren gewarren mentioned this issue Aug 17, 2020
Merged
gewarren added a commit that referenced this issue Aug 20, 2020
@gewarren @Youssef1313
URI paths on Unix (#20144)
2d6c6b2 
* Fixes #19965

Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gewarren gewarren

Labels
breaking-change Indicates a .NET Core breaking change 🏁 Release: .NET 5 Work items for the .NET 5 release doc-idea Indicates issues that are suggestions for new topics [org][type][category]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

URI paths on Unix gewarren/docs
3 participants
@dotnet-bot @gewarren @MihaZupan