[release/3.0] Double publish artifacts in cases of stable builds #8443
Conversation
There was a problem hiding this comment.
I don't understand, doesn't this defeat the point of the original change? I thought release infra (or release people) would perform this copy as part of the release?
(Also, it seems like it would be a better implementation to add a new project that doesn't have SuppressFinalPackageVersion set so it can calculate the stable version, rather than using a property function find replace which may unintentionally stabilize nonstable asset filenames.)
|
For reference: https://github.com/dotnet/core-setup/issues/8244 |
This will only turn the stable asset file names into non-stable (if they don't already exist). I also don't like setting SuppressFinalPackageVersion. I am thinking I'll tweak the version props so that it provides both suffixed and non-suffixed versions for use where needed. |
|
Ignore that, it was based on the misunderstanding that this was publishing to |
Nope:
|
|
Yeah, my mistake was pretty obvious after actually reading the code comment. 😄 |
|
@dagood I tweaked this a bit to avoid some corner cases and reworked the version props a bit so I don't have to override the IncludePrereleaseLabel... property. |
Directory.Build.targets
Outdated
| <ProductVersionSuffix Condition="'$(IncludePreReleaseLabelInPackageVersion)' == 'true'">-$(VersionSuffix)</ProductVersionSuffix> | ||
| <ProductBandVersion Condition="'$(ProductBandVersion)' == ''">$(MajorVersion).$(MinorVersion)</ProductBandVersion> | ||
| <ProductionVersion Condition="'$(ProductionVersion)' == ''">$(ProductBandVersion).$(PatchVersion)</ProductionVersion> | ||
| <ProductVersion>$(ProductionVersion)$(ProductVersionSuffix)</ProductVersion> | ||
| <ProductVersionWithSuffix>$(ProductionVersion)</ProductVersionWithSuffix> | ||
| <ProductVersionWithSuffix Condition="'$(IncludePreReleaseLabelInPackageVersion)' != 'true'">$(ProductionVersion)-$(VersionSuffix)</ProductVersionWithSuffix> |
There was a problem hiding this comment.
I'm a little confused this works, I would expect Arcade to unset VersionSuffix based on https://github.com/dotnet/arcade/blob/ca919f224b58b17e48d8786dd555ae9a1f6cdfa3/src/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets#L103-L112, and this would end up as 3.0.0-.
There was a problem hiding this comment.
And I think Arcade would have to introduce a new property to let us do this, since IIRC VersionSuffix is used directly by the NuGet pack targets (and that's why Arcade needs to clear it).
Stable assets do not publish to stable directories to avoid overwrite issues. But, the dotnet-install script expects the runtime version and directory to match, which they wouldn't. To deal with this, in cases of stable builds, copy all the stable branded bits to files with non-stable names. Thus, the suffixed directory will contain the stable file names (e.g. 3.0.1) as well as suffixed file names that work prior to release day. On release day, the directory is copied or renamed and the dotnet-install script will work with the official versions.
|
@dagood Finally working and doing what it is supposed to. |
Stable assets do not publish to stable directories to avoid overwrite issues. But, the dotnet-install script expects the runtime version and directory to match, which they wouldn't. To deal with this, in cases of stable builds, copy all the stable branded bits to files with non-stable names. Thus, the suffixed directory will contain the stable file names (e.g. 3.0.1) as well as suffixed file names that work prior to release day. On release day, the directory is copied or renamed and the dotnet-install script will work with the official versions.