This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.0] Add missing "--ci" option to Linux build #8301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c25b8b4)
dagood
added
the
* NO MERGE *
|
Was going to add a reject review for visibility, but I can't do that on my own PR. 🤷♂ Don't merge until branch is open. I'm also porting this to 3.1 individually to get it in faster there. |
mmitche
removed
the
* NO MERGE *
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports #8300 to
release/3.0.For internal build readiness.
This missing option caused the http cache not to be cleared at the right time. Clearing the http cache is a unfortunately necessary workaround to get authenticated NuGet restore to work, so this option being missing causes the internal build to fail if it tries to use an authenticated feed. More info at dotnet/arcade#3868 (comment) what this is about and why the issue didn't repro on the first pass.
Customer Impact
Allows internal builds.
Regression?
No.
Risk
Minimal, the change is scoped to a few very small steps in the build to set up tooling, and the flag is known to work in the very similar neighboring build steps.
@riarenas @JohnTortugo @dleeapho