Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing registry keys for Microsoft.AspNetCore.App #55368

Closed
joeloff opened this issue Apr 25, 2024 · 0 comments · Fixed by #55467
Closed

Add missing registry keys for Microsoft.AspNetCore.App #55368

joeloff opened this issue Apr 25, 2024 · 0 comments · Fixed by #55467
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-installers Includes: Installers

Comments

@joeloff
Copy link
Member

joeloff commented Apr 25, 2024

Description

During .NET Core 3.0, the SDK, Runtime and Desktop Runtime moved to using a single set of registry keys for Windows based installers to simplify detection. ASP.NET already had keys, but they were located in a completely different location in the registry.

App Services rapid update is looking at ways to simplify their detection logic and the registry keys are a feasible solution, but the ASP.NET keys are missing.

The old keys should be retained because removing them can break anyone relying on them This is just a request to add the central keys under HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\dotnet\Setup\InstalledVersions\<platform>\sharedfx. Note that these keys always go to the 32-bit registry view regardless of the MSI architecture.

Sample implementation

SDK implementation: https://github.com/dotnet/installer/blob/c949c4571bf2c334c30d2894f3de87552395c94b/src/redist/packaging/windows/registrykeys.wxs#L5C7-L9C19

Runtime/Desktop:
https://github.com/dotnet/arcade/blob/d54f6057363b8b249be56dcf8b91aa847f97a904/src/Microsoft.DotNet.Build.Tasks.Installers/build/wix/product/registrykeys.wxs#L8C7-L20C19

Backport

The changes should be backported to both 8.0 and 6.0 as those are LTS releases that will impact App Services.

@joeloff joeloff added the feature-installers Includes: Installers label Apr 25, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 25, 2024
@wtgodbe wtgodbe self-assigned this Apr 30, 2024
@wtgodbe wtgodbe added this to the Infrastructure milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-installers Includes: Installers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants