Get EmptyHttpResult in RDF via reflection (#45878) #46048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Get EmptyHttpResult in RDF via reflection * Always use instance property for checks * Favor Debug.Assert instead of early exception * Throw exception in RELEASE builds * Fix ifdef
captainsafia
requested review from
Tratcher,
BrennanConroy and
halter73
as code owners
ghost
added
the
|
Approved via email. |
|
Hi @captainsafia. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
brunolins16
approved these changes
Jan 12, 2023
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #45878 to
release/7.0.Description
This PR updates the
RequestDelegateFactoryto access theEmptyHttpResulttype via reflection instead of defining and emitting its ownEmptyHttpResultas part of the runtime code generation.Fixes #45063
Customer Impact
Without this change, users cannot adequately write test cases for applications that leverage filters and happen to return an empty result because the internal
EmptyHttpResultwas not public to assert on. This change provides a quality of life improvement and allows users to write more complete test cases for their applications.Regression?
Risk
Low risk because the surface area of the change is small (minimal APIs with endpoint filters).
Verification
Packaging changes reviewed?