[release/7.0] Remove legacy check to fix Runtime SiteExtension #46045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ghost
added
the
BrennanConroy
added
the
Servicing-consider
|
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
wtgodbe
approved these changes
Jan 12, 2023
leecow
added
Servicing-approved
|
Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #46033 to release/7.0
/cc @BrennanConroy
Remove legacy check to fix Runtime SiteExtension
Summary of the changes (Less than 80 chars)
Description
This package bundles the Runtime and ANCM and then modifies the web.config in App Service to use the bundled versions. A change in infrastructure in 7.0.1 caused the package to no longer bundle the Runtime.
Customer Impact
Azure App Service reported a customer complaining about the 7.0.1 package no longer functioning.
Regression?
7.0.0 builds set a legacy setting, starting in 7.0.1 the setting was no longer set. Something about arcade changes that removed the legacy variable.
Risk
We were just getting lucky before that a legacy setting was set in our builds that allowed the package to be built correctly. This removes the reliance on the setting, nothing else about the package being built changed.
Verification
Packaging changes reviewed?