Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component Vulnerability]please consider to upgrade node-fetch in @microsoft/signalr from @^2.x.x to @^3.1.1 #39672

Closed
1 task done
xinding1121 opened this issue Jan 21, 2022 · 4 comments · Fixed by #39741
Closed
1 task done
Labels
area-signalr Includes: SignalR clients and servers
Milestone

Comments

@xinding1121
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

The @microsoft/signalr has node-fetch@^2.6.1 as a dependency that is vulnerable to the exposure of sensitive information to an unauthorized actor. And it seems that this bug is fixed in node-fetch's latest release v3.1.1:

node-fetch/node-fetch#1449

please consider to upgrade node-fetch to @^3.1.1 to solve this problem.

Expected Behavior

upgrade node-fetch in @microsoft/signalr from @^2.6.1 to @^3.1.1 to solve this problem.

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

@javiercn javiercn added the area-signalr Includes: SignalR clients and servers label Jan 21, 2022
@adityamandaleeka
Copy link
Member

Triage: We should update this.

Note: you can also manually update this dependency in your own package.json file, and as long as there are no breaking changes it should work.

@adityamandaleeka adityamandaleeka added this to the 7.0-preview2 milestone Jan 21, 2022
@capnmidnight
Copy link

capnmidnight commented Jan 23, 2022

It's a major version bump for node-fetch. Doesn't that mean the node-fetch developers are signaling that there are breaking changes?

And isn't this issue a little more urgent than waiting for the release of a preview of the whole ASP.NET Core framework that most people won't use specifically because it's a preview? Also, isn't this numbering meant to coincide with releases of .NET Core? Doesn't that mean that 7, being an odd number, won't be an LTS release? Being that this is a security vulnerability, shouldn't it go as a patch of the current LTS release, 6?

@BrennanConroy
Copy link
Member

We will be updating main to explicitly target ^2.6.7 of node-fetch as the fix was made there and in the 3.x train.

For the patch branches we are not making any changes as we have the node-fetch dependency marked as ^2.6.1 which means you automatically get the latest patch when installing the SignalR package so you will get the secure version of the node-fetch package.

@xinding1121
Copy link
Author

We will be updating main to explicitly target ^2.6.7 of node-fetch as the fix was made there and in the 3.x train.

For the patch branches we are not making any changes as we have the node-fetch dependency marked as ^2.6.1 which means you automatically get the latest patch when installing the SignalR package so you will get the secure version of the node-fetch package.

Yeah. Thanks very much.

@dotnet dotnet locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants