Avoid declaring RazorPage<T>.Model as nullable by default (#39332) #39416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
|
Hi @pranavkm. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
pranavkm
added
the
Servicing-consider
|
Hi @pranavkm. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
JamesNK
approved these changes
Jan 10, 2022
|
@dotnet/aspnet-build could you help with the publicAPI analyzer file? |
You mean ignoring the "modified in a patch branch" issue? Once this is servicing approved sure. |
pranavkm
added
Servicing-approved
|
This was approved over email. Could I get some help getting this merged? |
|
Only failure is the expected API file check |
Elanis
added a commit
to Dysnomia-Studio/dysnomia-website
that referenced
this pull request
Jul 14, 2023
Bumps [Microsoft.AspNetCore.TestHost](https://github.com/dotnet/aspnetcore) from 6.0.1 to 6.0.2. <details> <summary>Release notes</summary> *Sourced from [Microsoft.AspNetCore.TestHost's releases](https://github.com/dotnet/aspnetcore/releases).* > ## .NET 6.0.2 > [Release](https://github.com/dotnet/core/releases/tag/v6.0.2) </details> <details> <summary>Commits</summary> - [`1dcf7ac`](dotnet/aspnetcore@1dcf7ac) [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-efcore... - [`608229f`](dotnet/aspnetcore@608229f) [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-runtim... - [`eb1c0a4`](dotnet/aspnetcore@eb1c0a4) Merge in 'release/6.0' changes - [`ef499fe`](dotnet/aspnetcore@ef499fe) Revert "[release/6.0] Switch to Windows.Amd64.Server2022.Open ([#39364](dotnet/aspnetcore#39364))" ([#39476](dotnet/aspnetcore#39476)) - [`5e8131b`](dotnet/aspnetcore@5e8131b) Merged PR 20577: Fix build errors - [`04a113d`](dotnet/aspnetcore@04a113d) Merge in 'release/6.0' changes - [`2bd9de6`](dotnet/aspnetcore@2bd9de6) Avoid declaring RazorPage\<T>.Model as nullable by default ([#39332](dotnet/aspnetcore#39332)) ([#39416](dotnet/aspnetcore#39416)) - [`6ffe8df`](dotnet/aspnetcore@6ffe8df) Merge in 'release/6.0' changes - [`d9521ac`](dotnet/aspnetcore@d9521ac) Don't exclude System.IO.Pipelines from TargetingPack version check ([#39302](dotnet/aspnetcore#39302)) - [`3b49ab1`](dotnet/aspnetcore@3b49ab1) Merge in 'release/6.0' changes - Additional commits viewable in [compare view](dotnet/aspnetcore@v6.0.1...v6.0.2) </details> <br /> Co-authored-by: Elanis <elanis@hotmail.com> Reviewed-on: https://gitea.dysnomia.studio/elanis/dysnomia-website/pulls/26 Co-authored-by: elanis <elanis@noreply.example.org> Co-committed-by: elanis <elanis@noreply.example.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Modelproperty forRazorPage<T>, the base class for MVC views, is declared as nullable. Having a nullable property reflects an accurate state when the model is not initialized as part of MVC's internal infrastructure. However, having the property be nullable is frustrating for user code when they specify a non-null model. We've had reports of users getting hundreds of errors in their app when they migrate to .NET 6 (which is when this API was annotated for nullability) with nullability enabled.Fixes #37510
Customer Impact
Difficulty in migrating to .NET 6.
Regression?
Risk
Verification
Packaging changes reviewed?