Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arpow: GenerateFileFromTemplate task causes BuildTools prebuilt #32492

Closed
dseefeld opened this issue May 7, 2021 · 1 comment · Fixed by #33449
Closed

Arpow: GenerateFileFromTemplate task causes BuildTools prebuilt #32492

dseefeld opened this issue May 7, 2021 · 1 comment · Fixed by #33449
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Comments

@dseefeld
Copy link

dseefeld commented May 7, 2021

Describe the bug

The GenerateFileFromTemplate task is defined in BuildTools, which isn't built with source-build. This will be reported as a prebuilt in Arpow when building offline and when prebuilt reporting is turned on. This task should either be moved to Arcade or moved into RepoTasks to ensure it can build and be used with source-build.

To Reproduce

When Arpow source-build CI is included (see #31445), in the generated results (Microsoft.SourceBuild.Intermediate.aspnetcore.*.nupkg), the file prebuilt-report/annotated-usage.xml will contain a reference to BuildTools, indicating that this is a prebuilt.

@javiercn javiercn added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 7, 2021
@dougbu
Copy link
Member

dougbu commented Jun 4, 2021

Resolution requires dotnet/arcade#7403 and adoption of the new package in this repo. Assigning to @JunTaoLuo since he owns at least the first (larger) part of this.

@ghost ghost closed this as completed in #33449 Jun 11, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 11, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants