Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving away from Mock due to race conditions #27042

Open
HaoK opened this issue Oct 19, 2020 · 3 comments
Open

Consider moving away from Mock due to race conditions #27042

HaoK opened this issue Oct 19, 2020 · 3 comments
Labels
affected-few This issue impacts only small number of customers area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework severity-minor This label is used by an internal tool task test-failure
Milestone

Comments

@HaoK
Copy link
Member

HaoK commented Oct 19, 2020

Followup to #27032 (comment)

Yup, there's a race condition in CastleCore which shows up once in a blue moon.

@HaoK HaoK added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-blazor Includes: Blazor, Razor Components labels Oct 19, 2020
@HaoK HaoK removed the area-blazor Includes: Blazor, Razor Components label Oct 19, 2020
@captainsafia
Copy link
Member

We discussed this during triage. In order to effectively remove these issues in our tests, we would need to remove all instances of Mock in our test suite, which is an expensive task.

An alternative consideration is to fix this issue (castleproject/Core#193) in CastleCore, but it's difficult to create a reliable repro for this situation.

Considering this doesn't happen frequently and it's difficult to fix, we'll live with it for now and leverage retries to work around it.

@captainsafia
Copy link
Member

cc: @BrennanConroy We discussed this during triage and figured you'd like to know what we discussed.

@captainsafia captainsafia added this to the Backlog milestone Oct 20, 2020
@ghost
Copy link

ghost commented Oct 20, 2020

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@javiercn javiercn added affected-few This issue impacts only small number of customers severity-minor This label is used by an internal tool labels Nov 6, 2020 — with ASP.NET Core Issue Ranking
@mkArtakMSFT mkArtakMSFT added area-web-frameworks and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Oct 20, 2021
@captainsafia captainsafia added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework and removed area-web-frameworks labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected-few This issue impacts only small number of customers area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework severity-minor This label is used by an internal tool task test-failure
Projects
None yet
Development

No branches or pull requests

4 participants