Fixes "InvalidOperationException" errors by performing async operations in SemaphoreSlim #796

cheenamalhotra · 2020-11-13T19:28:11Z

Fixes #459 #54 #786 #792
Rework over PR #579 with helpful ideas from @roji and @DavoudEshtehari

This PR fixes the issue where below exception would occur randomly due to SslStream.WriteAsync collisions.

System.InvalidOperationException: Invalid operation. The connection is closed.
   at Microsoft.Data.SqlClient.TdsParserStateObject.WritePacket(Byte flushMode, Boolean canAccumulate)

The design change introduces use of SemaphoreSlim with SNISslStream and SNINetworkStream overrides to ensure only 1 task is allowed to read/write to stream asynchronously at a time.

Not fixed in this issue

Queries with MultipleActiveResultSets=True (MARS) are very slow / time out on Linux #422 remains unfixed, investigations in progress.
Async reader may return wrong results on MacOS, Linux, WSL, Docker #659 remains unfixed, investigations in progress.

…erations in semaphore queue.

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs

...Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectManaged.cs

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNISslStream.cs

…onnections.

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIStreams.cs

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlUtil.cs

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlUtil.cs

Fixes "InvalidOperationException" errors by performing async write op…

0f27c26

…erations in semaphore queue.

cheenamalhotra requested review from DavoudEshtehari and JRahnama November 13, 2020 19:28

Add license header

aca1cc6

cheenamalhotra changed the title ~~Fixes "InvalidOperationException" errors by performing async write operations in Semaphore Concurrent Queue~~ Fixes "InvalidOperationException" errors by performing async operations in Semaphore Concurrent Queue Nov 13, 2020

Fix default include

65ec669

cheenamalhotra commented Nov 13, 2020

View reviewed changes

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs Show resolved Hide resolved

cheenamalhotra commented Nov 13, 2020

View reviewed changes

...Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectManaged.cs Show resolved Hide resolved

cheenamalhotra mentioned this pull request Nov 13, 2020

Async reader may return wrong results on MacOS, Linux, WSL, Docker #659

Closed

cheenamalhotra requested review from karinazhou and johnnypham November 13, 2020 21:04

cheenamalhotra added this to In progress in SqlClient v2.1 via automation Nov 13, 2020

cheenamalhotra added this to the 2.1.0 milestone Nov 13, 2020

cheenamalhotra mentioned this pull request Nov 13, 2020

WIP | Prevent WriteAsync collision #579

Closed

martyt reviewed Nov 13, 2020

View reviewed changes

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNISslStream.cs Outdated Show resolved Hide resolved

Suppress issue 422 from pipelines, till it gets fixed.

9ea1207

cheenamalhotra force-pushed the fix459 branch from 6f3a4e9 to a6e8db2 Compare November 15, 2020 01:49

Fix Async + Mars perf issue

7cc72ed

cheenamalhotra force-pushed the fix459 branch from a6e8db2 to 7cc72ed Compare November 15, 2020 17:54

cheenamalhotra added 2 commits November 16, 2020 12:14

Improvements

ddcfd41

Unblock Sync overrides

f6b5da4

cheenamalhotra added the 📈 Performance Use this label for performance improvement activities label Nov 17, 2020

roji reviewed Nov 17, 2020

View reviewed changes

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNISslStream.cs Outdated Show resolved Hide resolved

cheenamalhotra added 2 commits November 17, 2020 01:13

Move release to finally

3eaa757

Implementing SNINetworkStream fixes issue 422 for non-encrypted TCP c…

de07449

…onnections.

cheenamalhotra force-pushed the fix459 branch from 9004a29 to de07449 Compare November 17, 2020 09:42

cheenamalhotra mentioned this pull request Nov 17, 2020

InvalidOperationException when writing a lot of packets asynchronously and using managed SNI implementation #786

Closed

cheenamalhotra changed the title ~~WIP: Fixes "InvalidOperationException" errors by performing async operations in Semaphore Concurrent Queue~~ Fixes "InvalidOperationException" errors by performing async operations in Semaphore Concurrent Queue Nov 18, 2020

roji reviewed Nov 18, 2020

View reviewed changes

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIStreams.cs Show resolved Hide resolved

DavoudEshtehari reviewed Nov 18, 2020

View reviewed changes

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIStreams.cs Outdated Show resolved Hide resolved

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlUtil.cs Outdated Show resolved Hide resolved

cheenamalhotra added 2 commits November 18, 2020 11:12

Merge branch 'master' into fix459

3e90787

Simplified design as SemaphoreSlim is concurrent - confirmed.

b743e45

cheenamalhotra changed the title ~~Fixes "InvalidOperationException" errors by performing async operations in Semaphore Concurrent Queue~~ Fixes "InvalidOperationException" errors by performing async operations in SemaphoreSlim Nov 18, 2020

Improve

7d341af

Wraith2 reviewed Nov 18, 2020

View reviewed changes

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs Outdated Show resolved Hide resolved

Revert unwanted changes

f76e1c0

Wraith2 reviewed Nov 18, 2020

View reviewed changes

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs Show resolved Hide resolved

karinazhou reviewed Nov 18, 2020

View reviewed changes

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlUtil.cs Show resolved Hide resolved

cheenamalhotra force-pushed the fix459 branch 2 times, most recently from df81c95 to 2d69793 Compare November 18, 2020 23:59

Adding queue back to maintain FIFO for extra security.

10421a9

cheenamalhotra force-pushed the fix459 branch from 2d69793 to 10421a9 Compare November 19, 2020 00:00

Cleanup

d6b71ec

DavoudEshtehari approved these changes Nov 19, 2020

View reviewed changes

SqlClient v2.1 automation moved this from In progress to Reviewer approved Nov 19, 2020

DavoudEshtehari mentioned this pull request Nov 19, 2020

Implements SslStreamProxy write synchronization with SemaphoreSlim DavoudEshtehari/SqlClient#1

Open

cheenamalhotra merged commit cde615e into dotnet:master Nov 19, 2020

SqlClient v2.1 automation moved this from Reviewer approved to Done Nov 19, 2020

Charles-Gagnon mentioned this pull request Nov 20, 2020

Update SqlClient to 2.1.0 microsoft/sqltoolsservice#1124

Merged

cheenamalhotra mentioned this pull request Nov 23, 2020

Upgrade to Microsoft.Data.SqlClient v2.1.0 dotnet/efcore#23453

Closed

cheenamalhotra mentioned this pull request Feb 16, 2021

Invalid Operation, Error connection is closed. Azure Function with Azure SQL serverless dotnet/efcore#19842

Closed

This was referenced Mar 8, 2021

Bump Microsoft.Data.SqlClient from 2.0.0 to 2.1.2 StevenRasmussen/efcore#8

Closed

Bump Microsoft.Data.SqlClient from 2.0.0 to 2.1.2 svengeance/EntityFrameworkCore#10

Closed

CobeLapierre mentioned this pull request May 19, 2021

async issues with Microsoft.data.sqlclient SQLStreamStore/SQLStreamStore#509

Closed

cheenamalhotra mentioned this pull request Jun 17, 2021

Add ValueTask stream overloads on SNI streams and Waits #902

Merged

Charles-Gagnon mentioned this pull request Sep 20, 2021

Fix for cancel query by adding synchronous readers. microsoft/sqltoolsservice#1246

Merged

radekfojtik mentioned this pull request Feb 23, 2022

"The connection is closed" errors in System.Data.SqlClient - Async operations #1524

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes "InvalidOperationException" errors by performing async operations in SemaphoreSlim #796

Fixes "InvalidOperationException" errors by performing async operations in SemaphoreSlim #796

cheenamalhotra commented Nov 13, 2020 •

edited

Fixes "InvalidOperationException" errors by performing async operations in SemaphoreSlim #796

Fixes "InvalidOperationException" errors by performing async operations in SemaphoreSlim #796

Conversation

cheenamalhotra commented Nov 13, 2020 • edited

Not fixed in this issue

cheenamalhotra commented Nov 13, 2020 •

edited