Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | Add "Command Timeout" connection string property #722

Merged
merged 7 commits into from Sep 18, 2020

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Sep 3, 2020

This allow the default CommandTimeout of 30 seconds to be overridden, without any code changes.

fixes #614

QUESTION re missing docs:
I am not familiar with the way XML docs are created here, should I add something similar to this:
https://github.com/dotnet/SqlClient/blob/master/doc/snippets/Microsoft.Data.SqlClient/SqlCommand.xml#L1217
in the SqlConnection.xml and SqlConnectionString.xml files?

@cheenamalhotra
Copy link
Member

cheenamalhotra commented Sep 9, 2020

QUESTION re missing docs:
I am not familiar with the way XML docs are created here, should I add something similar to this:
https://github.com/dotnet/SqlClient/blob/master/doc/snippets/Microsoft.Data.SqlClient/SqlCommand.xml#L1217
in the SqlConnection.xml and SqlConnectionString.xml files?

Hi @ErikEJ

Yes, that's correct. Basically the XML files contain 1:1 documentation of all public APIs in the driver in order to use them in both NetFx and NetCore source to reduce duplication.

@ErikEJ ErikEJ marked this pull request as ready for review September 10, 2020 08:38
@ErikEJ
Copy link
Contributor Author

ErikEJ commented Sep 10, 2020

@cheenamalhotra This is ready for review now 😄

Extend test
@cheenamalhotra cheenamalhotra added this to In progress in SqlClient v2.1 via automation Sep 16, 2020
@cheenamalhotra cheenamalhotra added this to the 2.1.0-preview2 milestone Sep 16, 2020
@cheenamalhotra cheenamalhotra added the 🆕 Public API Use this label for new API additions to the driver. label Sep 16, 2020
SqlClient v2.1 automation moved this from In progress to Reviewer approved Sep 16, 2020
@cheenamalhotra cheenamalhotra merged commit 81052d6 into dotnet:master Sep 18, 2020
SqlClient v2.1 automation moved this from Reviewer approved to Done Sep 18, 2020
@cheenamalhotra cheenamalhotra changed the title Adds "Command Timeout" connection string option Feature | Add "Command Timeout" connection string property Sep 18, 2020
@ErikEJ
Copy link
Contributor Author

ErikEJ commented Sep 18, 2020

Thanks for getting this in, a very useful new feature imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 Public API Use this label for new API additions to the driver.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Is it possible to add keyword "Command Timeout" to the connection string
3 participants