AE with enclaves - multi-platform and .NET Standard 2.1 support #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
[skip ci]
cheenamalhotra
approved these changes
Aug 18, 2020
johnnypham
commented
Aug 18, 2020
...t.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/AlwaysEncryptedEnclaveProviderUtils.cs
Outdated
Show resolved
Hide resolved
karinazhou
reviewed
Aug 19, 2020
...t.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/AlwaysEncryptedEnclaveProviderUtils.cs
Show resolved
Hide resolved
karinazhou
reviewed
Aug 21, 2020
....Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/VirtualSecureModeEnclaveProviderBase.cs
Outdated
Show resolved
Hide resolved
karinazhou
reviewed
Aug 21, 2020
src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj
Outdated
Show resolved
Hide resolved
JRahnama
approved these changes
Aug 21, 2020
karinazhou
reviewed
Aug 21, 2020
...crosoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj
Outdated
Show resolved
Hide resolved
karinazhou
approved these changes
Aug 21, 2020
cheenamalhotra
added
the
🆕 Public API
cheenamalhotra
approved these changes
Aug 21, 2020
TrayanZapryanov
pushed a commit
to TrayanZapryanov/SqlClient
that referenced
this pull request
Aug 31, 2020
TrayanZapryanov
added a commit
to TrayanZapryanov/SqlClient
that referenced
this pull request
Aug 31, 2020
… 2.1 support (dotnet#676)" This reverts commit 30ebb76.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary change involves a refactoring to move from the Windows-only CNG implementation to the ECDH and RSA base classes, which use a platform-specific implementation. A
KeyConverterclass is added for key serialization and deserialization to reproduce the CNG keys.The driver will now get compiled for .NET Standard 2.1, which will include enclave-related files. The NetCoreApp suffix for some enclave files have been removed.
AE tests have been modified to use a wrapper fixture class which will instantiate a platform-specific fixture for each test class. The AKV fixture class has also been modified to enable enclaves.
An Ubuntu enclave-enabled pipeline has been set up to run tests against .NET Standard 2.1.