Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | Provide the same Managed Identity support as Azure.Identity #947

Closed
MarcWils opened this issue Mar 3, 2021 · 4 comments · Fixed by #1043
Closed

Feature | Provide the same Managed Identity support as Azure.Identity #947

MarcWils opened this issue Mar 3, 2021 · 4 comments · Fixed by #1043
Labels
💡 Enhancement New feature request

Comments

@MarcWils
Copy link

MarcWils commented Mar 3, 2021

#616 introduced support for Managed Identities.

This may work for the most common scenarios. However, both Azure.Identity and Microsoft.Azure.Services.AppAuthentication have implementations which also support Service Fabric.

Using the SqlAuthenticationProvider from Microsoft.Azure.Services.AppAuthentication works in a Service Fabric application. The one from Microsoft.Data.SqlClient doesn't.

This may also be related to #771. However, the discussion there seems to mainly focussing on caching the access token.

It seems a choice has to be made between extending the built-in support in Microsoft.Data.SqlClient or providing seamless integration with Azure.Identity.

@cheenamalhotra
Copy link
Member

Hi @MarcWils

Yes, we will be working on that soon, now that we've bumped up minimum .NET Framework version supported to be v4.6.1.
From #771 discussions, access Token caching changes are currently not finalized, so that's out of scope from that issue.

We will be replacing calls for token acquisition to use Azure.Identity instead and the same way for Managed Identity authentication.

@cheenamalhotra cheenamalhotra added the 💡 Enhancement New feature request label Mar 5, 2021
@ericsampson
Copy link

ericsampson commented Mar 22, 2021

Thanks @cheenamalhotra.

What does "(access_token caching) is out of scope" mean? I'm hoping that is going to be part of this implementation. Thanks!!

@cheenamalhotra
Copy link
Member

Hi @ericsampson

There are 2 access token topics in that thread:

  1. Integrate with Azure.Identity #771 (comment) (SqlConnection.AccessToken property - not relevant to Azure.Identity support and is in internal discussions for any potential improvements - I meant this before :))
  2. Integrate with Azure.Identity #771 (comment) (Relates to caching tokens internally when acquiring from TokenCredential API, for which we will consider best options we have to implement/use caching, using Azure.Identity)

@ericsampson
Copy link

Thanks, there's a lot of moving pieces to keep track of in these conversations, especially since they're spread across a bunch of issues :)

@cheenamalhotra cheenamalhotra added this to To do in SqlClient v3.0 via automation Apr 20, 2021
@cheenamalhotra cheenamalhotra moved this from To do to In Progress in SqlClient v3.0 Apr 20, 2021
@cheenamalhotra cheenamalhotra moved this from In Progress to Review In Progress in SqlClient v3.0 May 15, 2021
SqlClient v3.0 automation moved this from Review In Progress to Done May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Enhancement New feature request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants