Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exception Summarization for Microsoft.Data.SqlClient Exceptions #2461

Open
bbrandt opened this issue Apr 11, 2024 · 1 comment
Open

Add Exception Summarization for Microsoft.Data.SqlClient Exceptions #2461

bbrandt opened this issue Apr 11, 2024 · 1 comment
Labels
💡 Enhancement New feature request 🙌 Up-for-Grabs Anyone interested in working on it can ask to be assigned

Comments

@bbrandt
Copy link

bbrandt commented Apr 11, 2024

Is your feature request related to a problem? Please describe.

Loosely related to #649 and #2342 as these are also about surfacing information about exceptions and the hope is that the result of IsTransient and the ErrorNumber properties would be able to give additional context in a SQL Server specific IExceptionSummaryProvider implementation.

Describe the solution you'd like

Exception summarization is a new feature of .NET 8. All examples of Exception summarization are configured with .AddExceptionSummarizer(static builder => builder.AddHttpProvider()), but when I see this, I instantly think of needing a .AddExceptionSummarizer(static builder => builder.AddSqlServerProvider()) that would include information like ErrorNumber, if the error is believed to be transient, along with the usual exception summarization.

Describe alternatives you've considered

  • Each project writes their own IExceptionSummaryProvider implementation
  • A Microsoft.Data.SqlClient.ExceptionSummarization open-source project is started

Additional context

Likely Microsoft.Data.SqlClient will not want to take a dependency on Microsoft.Extensions.Diagnostics.ExceptionSummarization to be able to implement the IExceptionSummaryProvider interface. This would pretty much require a separate Microsoft.Data.SqlClient.ExceptionSummarization NuGet package to be created, right?

@JRahnama JRahnama added this to Needs triage in SqlClient Triage Board via automation Apr 11, 2024
@JRahnama JRahnama added 💡 Enhancement New feature request and removed untriaged labels Apr 17, 2024
@JRahnama JRahnama moved this from Needs triage to Ideas for Future in SqlClient Triage Board Apr 17, 2024
@JRahnama JRahnama added the 🙌 Up-for-Grabs Anyone interested in working on it can ask to be assigned label Apr 17, 2024
@JRahnama
Copy link
Member

@bbrandt it is an interesting feature to have. You are right we are hesitant to add additional dependencies to the driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Enhancement New feature request 🙌 Up-for-Grabs Anyone interested in working on it can ask to be assigned
Projects
SqlClient Triage Board
  
Ideas for Future
Development

No branches or pull requests

2 participants