Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Azure.Identity 1.5 once it's available #1117

Closed
ericsampson opened this issue Jun 15, 2021 · 3 comments
Closed

Upgrade to Azure.Identity 1.5 once it's available #1117

ericsampson opened this issue Jun 15, 2021 · 3 comments
Labels
💡 Enhancement New feature request

Comments

@ericsampson
Copy link

ericsampson commented Jun 15, 2021

Is your feature request related to a problem? Please describe.

Following up on #730, the currently used Azure.Identity library versions don't handle the situation well when VS/VSCode has with multiple credentials signed in, which is fairly common (guest tenants etc).
This is being addressed here, which is planned to land in the next version of the library (1.5)

There's also a question if there is work on the Azure SQL Server side to support sending the tenant ID in the challenge header in order to light up this feature. I'm not sure where this should get filed.

Describe the solution you'd like

Upgrade SqlClient to Azure.Identity once it's available.

Describe alternatives you've considered

There are workarounds, but it requires setting environment variables on each dev's machine, so is not ideal.

@johnnypham johnnypham added the 💡 Enhancement New feature request label Jun 16, 2021
@johnnypham
Copy link
Contributor

Hi @ericsampson, thanks for making this. We'll keep an eye out for new releases.

@ericsampson
Copy link
Author

Thanks Johnny.

It might be good to look at this together with #1106 , because according to the Identity issue I linked to originally, the user might have to specify a EnableTenantDiscovery option for the behavior to take effect. So there would have to be a way to pass that information to SqlClient in the connection string, similar to how in #1106 people are wanting to do things like select which token providers are used. Cheers

@JRahnama
Copy link
Member

Closing this issue as package has been upgraded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Enhancement New feature request
Projects
None yet
Development

No branches or pull requests

3 participants